#4578 closed discussion (fixed)
Q: What models are tested?
Reported by: | Owned by: | somebody | |
---|---|---|---|
Priority: | high | Milestone: | |
Component: | Testing Framework | Version: | |
Keywords: | Cc: |
Description
Up to now I thought you are testing all models that extend from Modelica.Icons.Example
but that seems to wrong.
Why is this model included in the tests?
Change History (7)
comment:1 by , 7 years ago
comment:2 by , 7 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
OK, thanks for clarifying.
I will remove the experiment annotation from that model.
comment:3 by , 7 years ago
Component: | *unknown* → Testing Framework |
---|---|
Milestone: | Future |
Type: | defect → discussion |
comment:4 by , 6 years ago
Just a note to myself:
Annotation experiment and tolerance is not enough to trigger a test,
some other setting like StopTime is also required.
https://github.com/thorade/HelmholtzMedia/commit/8b0f32b056d804a9c27e4fd1d39e612a5796e3fe
https://github.com/thorade/HelmholtzMedia/commit/31a5ae702a25a9411c44976e2787a37a439d5edb
comment:5 by , 6 years ago
Indeed I understand the StopTime
annotation is what Hudson looks for, which may be a problem for models with StopTime = 1 saved by Dymola, which won't write the StopTime annotation in this case because it's the default.
Should we actually just look for the experiment annotation?
follow-up: 7 comment:6 by , 6 years ago
The Modelica language does not have a default for StopTime so you don't know the time scale unless it is given...
comment:7 by , 6 years ago
Replying to sjoelund.se:
The Modelica language does not have a default for StopTime so you don't know the time scale unless it is given...
True. What I just meant is that examples prepared with Dymola and using its default StopTime won't be included unless you add the annotation manually or change StopTime to any other value.
Only the models that have the experiment annotation are tested.