Opened 6 years ago

Closed 4 years ago

#4639 closed defect (fixed)

FMI modelDescription contains no units

Reported by: rfranke Owned by: lochel
Priority: high Milestone: 1.16.0
Component: FMI Version:
Keywords: Cc:

Description

CodegenFMUCommon.tpl contains the comment:

    /* Don't generate the units for now since it is wrong. If you generate a unit attribute here then we must add the UnitDefinitions tag section also. */

This appears not true. Note that OMEdit supports units as well.

Change History (4)

comment:1 Changed 6 years ago by rfranke

PR2039 (​https://github.com/OpenModelica/OMCompiler/pull/2039/) introduces units to FMI2. A separate commit omits displayUnit because FMI2XML failed for some tests, e.g. for the units "deg" and "bar".

Can someone fix FMI2XML, so that displayUnit can be enabled as well?

comment:2 Changed 5 years ago by casella

  • Milestone changed from 1.13.0 to 1.14.0

Rescheduled to 1.14.0 after 1.13.0 releasee

comment:3 Changed 4 years ago by casella

  • Milestone changed from 1.14.0 to 1.16.0

Releasing 1.14.0 which is stable and has many improvements w.r.t. 1.13.2. This issue is rescheduled to 1.16.0

comment:4 Changed 4 years ago by casella

  • Resolution set to fixed
  • Status changed from new to closed

I guess this issue is now obsolete, in particular after #5845 and #5920 were fixed.

Please reopen if this is not the case.

Note: See TracTickets for help on using tickets.