Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#4682 closed defect (duplicate)

Vectorization of functions fails in NF

Reported by: Francesco Casella Owned by: Per Östlund
Priority: high Milestone: 2.0.0
Component: New Instantiation Version:
Keywords: Cc:

Description

Please check

https://libraries.openmodelica.org/branches/newInst/Modelica_3.2.2/files/Modelica_3.2.2_Modelica.Blocks.Examples.PID_Controller.err

The following error is generated:

[/OpenModelica/OMCompiler/Compiler/NFFrontEnd/NFSimplifyExp.mo:176:9-176:128:writable]
Error: Internal error Unimplemented case for max({{1}, {1}, {1}})
in NFSimplifyExp.postSimplify

I guess this would be ok if vectorization as defined in section 12.4.6 of the spec were applied

Change History (4)

comment:1 by Per Östlund, 7 years ago

Resolution: duplicate
Status: newclosed

Duplicate of #4660.

in reply to:  1 ; comment:2 by Francesco Casella, 7 years ago

Replying to perost:

Duplicate of #4660.

I understood the problem here, besides lack of function evaluation, was lack of function vectorization, which is the reason why I opened a separate ticket.

Do I miss something?

in reply to:  2 comment:3 by Per Östlund, 7 years ago

Replying to casella:

Replying to perost:

Duplicate of #4660.

I understood the problem here, besides lack of function evaluation, was lack of function vectorization, which is the reason why I opened a separate ticket.

Do I miss something?

We are missing vectorization, but that is not the issue in this particular case since max is handled as a special case during typing. In this case the call to max has already been typed, and the actual issue is that we don't have any function evaluation of max. I have already implemented evaluation of max in my local branch which handles this case, which I will push in tomorrow.

comment:4 by Francesco Casella, 7 years ago

Ok, thanks :)

Note: See TracTickets for help on using tickets.