#4966 closed defect (fixed)
Overconstrained connectors not handled by the NF
Reported by: | Francesco Casella | Owned by: | Adrian Pop |
---|---|---|---|
Priority: | high | Milestone: | 1.13.0 |
Component: | New Instantiation | Version: | |
Keywords: | Cc: | Per Östlund |
Description
Overconstrained connectors are still not handled by the NF. This invalidates most MultiBody models, as well as other libraries (like PowerSystems) that rely on this feature.
This is a well-known issue, see #4138, just adding it as a separate ticket for the record.
Change History (3)
comment:1 by , 6 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:2 by , 6 years ago
Milestone: | 2.0.0 → 1.13.0 |
---|
comment:3 by , 6 years ago
Cc: | added |
---|
I have been trying not to redo some of the things when handing the overconstrained connection graph but unfortunately that was not easily possible. I think we should expand the connectors once and then reuse the expansion in several of the phases from NFFlatten.flatten.
As is currently implemented I need to do the connector expansion several times:
- for retrieving the actual component references of the overconstrained components in the connect, this is needed for typing the
zeros(:) = equalityConstraint(A.OCGcomp, B.OCGComp);
. This has to happen during typing. - again for retrieving the actual component references of the overconstrained components in the connect for building the graph, during flattening.
- when handling the connection sets, this is done by default
Maybe we could expand the connectors once and store them in the Equation.CONNECT and don't do it again for 2) and 3).
@perost: what do you think about this?
Fixed with PRs:
https://github.com/OpenModelica/OMCompiler/pull/2578
https://github.com/OpenModelica/OMCompiler/pull/2579