Expandable connectors support is missing from the NF

[Francesco Casella]

Another well-known issue, added for the record.

[Adrian Pop]

Partial implementation in:
​https://github.com/OpenModelica/OMCompiler/pull/2608

[Adrian Pop]

Short on what remains:
Not sure how/when to add the virtual crefs as components in the ClassTree.
We need to collect all connects, do the union of expandable connectors and
then add all the virtual components to the FLAT_TREE before we do the
flattening. Also, is unclear how to handle expandable connectors that are
inner/outer.

Per, any thoughts on these things?

My feeling is we could add directly the typed components from the other side to the expandable connector class (care is needed if they are indexed arrays on any side) as if we add the SCode.Element definition from the other side and we instantiate the connector is a different scope and we might not be able to lookup the type paths.

[Francesco Casella]

@perost, it seems that some libraries (e.g. Buildings) use expandable connectors heavily, so fixing this issue should boost the overall NF coverage significantly. In view of the Annual Meeting presentation it may be worthwhile to complete this task, if what remains is not much.

[Per Östlund]

Replying to casella:

@perost, it seems that some libraries (e.g. Buildings) use expandable connectors heavily, so fixing this issue should boost the overall NF coverage significantly. In view of the Annual Meeting presentation it may be worthwhile to complete this task, if what remains is not much.

Yes, I've made the same observation myself, and was planning on starting to work in it soon (probably next week).

[Francesco Casella]

With the last commits by @perost, the NF implementation of expandable connectors is now complete. This allowed the simulation of about 500 additional models in the newInst testsuite.