Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#5282 closed defect (fixed)

Wait a bit more before applying a changed variable filter string in OMEdit

Reported by: casella Owned by: adeas31
Priority: critical Milestone: 1.13.2
Component: OMEdit Version:
Keywords: Cc: Andrea.Bartolini

Description

As reported in ticket:5273#comment:3, if you use variable filtering in a model with thousand of variables (which is normal in real-life industrial models) you wait a lot of time waiting the filter is applied each time you add a character in the filter.

I would personally suggest to implement the following behaviour:

  • the filter is applied immediately if the enter key is pressed
  • otherwise it is applied after 2 seconds have elapsed from the last key pressed

I think this would make the feature a lot more usable. Requiring the user to press enter would be disorienting for users who are used to see the filter acting without such action, and would be puzzled to see it not working. @Andrea.Bartolini, do you agree?

It would be nice to have it in 1.13.1, as long as it doesn't delay the release, otherwise let's move it to 1.14.0.

Change History (5)

comment:1 Changed 5 years ago by Andrea.Bartolini

I agree with Francesco.

Maybe also useful to have a flag in the setting parameters to allow the user to change the time delay, but this can be done in the 1.14.0.

comment:2 Changed 5 years ago by casella

  • Milestone changed from 1.13.1 to 1.14.0

comment:3 Changed 5 years ago by adeas31

  • Milestone changed from 1.14.0 to 1.13.2
  • Resolution set to fixed
  • Status changed from new to closed

Done in e519aa1/OMEdit.

comment:4 Changed 5 years ago by adeas31

O yeah and the interval is customizable via the settings.

comment:5 Changed 5 years ago by casella

Thanks Adeel, we appreciate this :)

Note: See TracTickets for help on using tickets.