Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#5282 closed defect (fixed)

Wait a bit more before applying a changed variable filter string in OMEdit

Reported by: Francesco Casella Owned by: Adeel Asghar
Priority: critical Milestone: 1.13.2
Component: OMEdit Version:
Keywords: Cc: Andrea Bartolini

Description

As reported in ticket:5273#comment:3, if you use variable filtering in a model with thousand of variables (which is normal in real-life industrial models) you wait a lot of time waiting the filter is applied each time you add a character in the filter.

I would personally suggest to implement the following behaviour:

  • the filter is applied immediately if the enter key is pressed
  • otherwise it is applied after 2 seconds have elapsed from the last key pressed

I think this would make the feature a lot more usable. Requiring the user to press enter would be disorienting for users who are used to see the filter acting without such action, and would be puzzled to see it not working. @Andrea.Bartolini, do you agree?

It would be nice to have it in 1.13.1, as long as it doesn't delay the release, otherwise let's move it to 1.14.0.

Change History (5)

comment:1 by Andrea Bartolini, 6 years ago

I agree with Francesco.

Maybe also useful to have a flag in the setting parameters to allow the user to change the time delay, but this can be done in the 1.14.0.

comment:2 by Francesco Casella, 6 years ago

Milestone: 1.13.11.14.0

comment:3 by Adeel Asghar, 6 years ago

Milestone: 1.14.01.13.2
Resolution: fixed
Status: newclosed

Done in e519aa1/OMEdit.

comment:4 by Adeel Asghar, 6 years ago

O yeah and the interval is customizable via the settings.

comment:5 by Francesco Casella, 6 years ago

Thanks Adeel, we appreciate this :)

Note: See TracTickets for help on using tickets.