Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#5303 closed defect (fixed)

Should the default for --maxMixedDeterminedIndex be increased?

Reported by: Francesco Casella Owned by: Lennart Ochel
Priority: high Milestone: 1.14.0
Component: Backend Version:
Keywords: Cc: Willi Braun, Karim Adbdelhak, Andreas Heuermann, Andrea Bartolini

Description

The default value of the --maxMixedDeterminedIndex flag is currently set to 3. There are quite some models in the OMC testsuite that fail because such index is greater than 3. Andrea has successfully managed to initialize models with index up to 20. I'm not sure why the default was chosen to be so low, I guess for performance reasons, but I strongly suspect that increasing it to 6 or 10 could significantly improve the overall coverage of the testsuite, without impacting the code generation time significantly.

I would suggest to try this out and check the impact on performance and regressions/improvements on Hudson.

Can someone try this out and report?

Change History (4)

comment:1 by Francesco Casella, 6 years ago

Cc: Andrea Bartolini added

comment:2 by Karim Adbdelhak, 6 years ago

I pushed it to 10 in PR2920, locally i had no issues so it should work fine.

comment:3 by Karim Adbdelhak, 6 years ago

Resolution: fixed
Status: newclosed

comment:4 by Karim Adbdelhak, 6 years ago

Fixed in commit.

Note: See TracTickets for help on using tickets.