Opened 6 years ago
Closed 6 years ago
#5492 closed defect (fixed)
Update the MSL 3.2.3 to the contents of the maintenance branch for the 1.14.0 release
Reported by: | Francesco Casella | Owned by: | Martin Sjölund |
---|---|---|---|
Priority: | blocker | Milestone: | 1.14.0 |
Component: | Third-Party Libraries | Version: | |
Keywords: | Cc: |
Description
In the last few months we have addressed a few issues that affected the coverage of MSL by submitting PR's to the MSL GitHub repo. I tried to make sure that the critical ones were back-ported to the MSL 3.2.3 mainteanance branch as well. Some are still pending, awaiting review.
Right before the 1.14.0 release, we should make sure that all these fixes are merged into the version of MSL 3.2.3 that we ship with the tool.
Change History (5)
comment:1 by , 6 years ago
comment:2 by , 6 years ago
Resolution: | → invalid |
---|---|
Status: | new → closed |
Aha, sorry, I was not aware of that.
comment:3 by , 6 years ago
Resolution: | invalid |
---|---|
Status: | closed → reopened |
I still can't see PR #2876 in the last commit, nor I see its effect in the MSL 3.2.3 patch, is it because it has not been processed yet?
comment:4 by , 6 years ago
The MSL patch contains our own library changes. It needs to update whenever there are changes to the library. It has nothing to do with processing changes to the library.
Here you can see the latest commit that we have for branch: maint/3.2.3
https://github.com/OpenModelica/OMLibraries/blob/master/repos.json#L584
You can compare it with the latest commit to MSL branch maint/3.2.3
https://github.com/modelica/ModelicaStandardLibrary/tree/maint/3.2.3
and as you can see is the same hash: 2556186408a4626efd9132759f74f03ef4d019f4
.
This means than whenever you build OpenModelica this hash will be checked out for MSL 3.2.3 and the library delivered with the installer or via apt will contain the latest changes.
comment:5 by , 6 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
OK, I incorrectly understood that we were porting commits to the maintenance branch into the patch file, but in fact our MSL 3.2.3 points to maint/3.2.3 already.
Thank you for explaining!
That is done automatically by OpenModelica_UPDATE_LIBRARIES Hudson job.
You can see the update in the last commit to OMLibraries (3281d7/OMLibraries):
https://github.com/OpenModelica/OMLibraries/commit/3281d772d7f9205b0a659ae257272ca3ddb72fd8#diff-f6bc6ed387e7cea3273d098d8dfdad35R507