#5507 closed defect (fixed)
OMEdit crashes when text is written in icon view
| Reported by: | Andrea Bartolini | Owned by: | John Tinnerholm |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.14.0 |
| Component: | OMEdit | Version: | v1.14.0-dev-nightly |
| Keywords: | Cc: | Francesco Casella |
Description
Steps to reproduce the issue:
1) create a new model "Test" in OMEdit (File->New Modelica Class)
2) in the new created model, go to the Icon View
3) insert a text in the icon -> Text Property dialog opens
4) type "test" string in the Text field
5) press OK, OMEdit crashes
If you press OK without change the text in the Text field then OMEdit works properly.
OMEdit - OpenModelica Connection Editor
Connected to OpenModelica 1.14.0~dev-26494-g4d4d809
Sysop: Ubuntu 16.04
Change History (7)
comment:1 by , 5 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:2 by , 5 years ago
comment:3 by , 5 years ago
Looking through it again it does not seem to be the case that my changes caused this crash rather 53f0fcbc8aa1ab13cd05be2c26c83ec0e2794ec3 seems to be the culprint.
It seems like the cause of this issue is incorrect bounds checking in that commit.
I just made a PL (https://github.com/OpenModelica/OpenModelica/pull/222), there might be some other things in text annotation to consider as well. I will keep you posted
comment:4 by , 5 years ago
| Component: | NF API → OMEdit |
|---|
comment:5 by , 5 years ago
Should be solved in: https://github.com/OpenModelica/OpenModelica/commit/75252ef16838be063a2877e78936d97584d300cb
Awaiting verification
comment:6 by , 5 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
More fixes in: f9fe35/OpenModelica.
comment:7 by , 5 years ago
It works fine on my PC.
Connected to OpenModelica 1.14.0~dev-26512-g43bbd73
Sysop: Ubuntu 16.04
I recently updated and "improved" the drawing functionality of the icon view, so I am to blame. I will take it and resolve it today or tomorrow