Opened 5 years ago
Closed 2 years ago
#5816 closed defect (fixed)
Issues with icon extents in diagrams
| Reported by: | Francesco Casella | Owned by: | Adeel Asghar |
|---|---|---|---|
| Priority: | high | Milestone: | 1.20.0 |
| Component: | OMEdit | Version: | |
| Keywords: | Cc: |
Description (last modified by )
Please check the attached test package, which reproduces issues I'm facing with the model that will be presented at the Annual Meeting keynote.
Model M0 has an icon annotation with extent and graphics. Model M01 extends M0 with no annotations, while model M02 extends it and re-adds the icon extent annotation.
Now, check the diagrams of M1, M11, and M12. In principle, they should be the same. In practice, M1 has the expected appearence of the instance of M0, while M11, where the instance of M01 has the same extent as in the previous model, the rendering is completely wrong. Apparently, the graphics annotation is inherited correctly, while the extent annotation is not. Please make sure it is. The diagram of M12 looks instead fine, since the extent is re-added to M02.
Finally, when looking at the diagram of M2, the icon of the instance of M1 should be centered in the rectangle - unfortunately, it isn't. Furthermore, as soon as I grab it by one corner to resize it, it jumps in a different position. I guess the two issues are related.
It would be good if we could fix this in 1.15.0 already. This kind of issues make models developed with other tools unreadable, which is extremely annoying.
Thanks!
Attachments (1)
Change History (10)
by , 5 years ago
| Attachment: | TestIconExtent.mo added |
|---|
comment:1 by , 5 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 5 years ago
| Status: | new → accepted |
|---|
comment:3 by , 5 years ago
| Resolution: | → fixed |
|---|---|
| Status: | accepted → closed |
Fixed in 58c7a53/OpenModelica.
comment:4 by , 5 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Reopening this ticket as the following issue is not fixed yet,
Finally, when looking at the diagram of M2, the icon of the instance of M1 should be centered in the rectangle - unfortunately, it isn't. Furthermore, as soon as I grab it by one corner to resize it, it jumps in a different position. I guess the two issues are related.
comment:5 by , 5 years ago
| Milestone: | 1.15.0 → 1.16.0 |
|---|
Release 1.15.0 was scrapped, because replaceable support eventually turned out to be more easily implemented in 1.16.0. Hence, all 1.15.0 tickets are rescheduled to 1.16.0
comment:7 by , 4 years ago
| Milestone: | 1.17.0 → 1.18.0 |
|---|
Retargeted to 1.18.0 because of 1.17.0 timed release.
comment:9 by , 2 years ago
| Milestone: | → 1.20.0 |
|---|---|
| Resolution: | → fixed |
| Status: | reopened → closed |
Fixed in 61bb5d5/OpenModelica.
I started working on it this week. Already have a fix for it in my working copy. Hopefully finish it up next week.