Opened 5 years ago
Closed 4 years ago
#5892 closed enhancement (wontfix)
solartherm library example
Reported by: | Owned by: | Martin Sjölund | |
---|---|---|---|
Priority: | high | Milestone: | 1.17.0 |
Component: | Build Environment | Version: | v1.14.1 |
Keywords: | Cc: |
Description
There are no examples for SolarTherm library in the latest official release (1.14.1). Please do add them.
Change History (6)
comment:1 by , 5 years ago
comment:2 by , 5 years ago
https://github.com/SolarTherm/SolarTherm/tree/master/examples
But it's called "examples" and there is no way I am going to ship a package called that... Maybe if it was called SolarThermExamples. Better would be to have SolarTherm.Examples.
comment:3 by , 5 years ago
There are good arguments both in favour and against having examples in the same library. But I agree with @sjoelund.se that "Examples" is not a good name for a top-level pacage.
comment:4 by , 5 years ago
Already reported upstream by https://github.com/SolarTherm/SolarTherm/pull/72
comment:5 by , 5 years ago
Milestone: | 1.14.1 → 1.17.0 |
---|
comment:6 by , 4 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
I'm sorry, it is not clear to me what you mean here. Do you mean there is another package with examples that use SolarTherm? Could you point out which one and where do we find it?