Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#6032 closed defect (fixed)

Bad display and Crash when viewing a diagram in plotting perspective

Reported by: massimo ceraolo Owned by: Adeel Asghar
Priority: critical Milestone: 1.16.0
Component: OMEdit Version: v1.16.0-dev
Keywords: Cc:

Description

I often use diagram display in plotting perspective. This feature has some internal bug, since when I use it a crash often occurs after some usage.

Now I've found a case that probably is related. Consider the model

PowerGrids.Examples.IEEE14bus.IEEE14busLine1to5Opening.

When opened, it shows very badly in plotting perspective: only the BoleanSOurce block is shown (see enclosed impage.png).

After this very bad display, OMEdit typically crashes very soon: I've just sent a report a few minutes ago.

Done using v1.16-0-dev.03

Attachments (1)

Image.png (62.9 KB ) - added by massimo ceraolo 4 years ago.

Download all attachments as: .zip

Change History (15)

by massimo ceraolo, 4 years ago

Attachment: Image.png added

comment:1 by massimo ceraolo, 4 years ago

@adeas can you see if you can replicate this (I mean you see something similar to Image.png)?
In case you do, you'll probably be able to find a serious crash-causing bug in OM.
And that would enhance OMEdit usability significantly.

comment:2 by Francesco Casella, 4 years ago

I just tried this out. I confirm that the diagram in the plotting perspective is broken, as it only shows the signal source and a piece of connection line. Though it is a bit different in my case, maybe @ceraolo is still on Windows 7?

I'm not getting any crashes myself, at least not after a few minutes.

in reply to:  2 comment:3 by massimo ceraolo, 4 years ago

Replying to casella:

I just tried this out. I confirm that the diagram in the plotting perspective is broken, as it only shows the signal source and a piece of connection line. Though it is a bit different in my case, maybe @ceraolo is still on Windows 7?

Win 10 build 1909

comment:4 by Adeel Asghar, 4 years ago

I get the same behavior as reported by @casella.

comment:5 by Adeel Asghar, 4 years ago

Resolution: fixed
Status: newclosed

The display issue is fixed in e15e9e2/OpenModelica.

comment:6 by massimo ceraolo, 4 years ago

I've just tried.
Got the diagram, but also an immediate crash.
I sent the crash report. It should be good for the analysis, since the actions I made were just

  • open OMEdit
  • load PowerGrids
  • open PowerGrids.Examples.IEEE14bus.IEEE14busLine1to5Opening
  • go in the plotting perspective and show the diagram
  • close the diagram (in plotting perspective) -> CRASH

comment:7 by massimo ceraolo, 4 years ago

Resolution: fixed
Status: closedreopened

Since there is more than just a suspect that there is some relationship between plot perspective display and crash, I think it is better to keep this ticket open.
@adeas, I'm looking forward to seeing what you can in infer from today's crash report.

Last edited 4 years ago by massimo ceraolo (previous) (diff)

comment:8 by Francesco Casella, 4 years ago

I tried this myself. I confirm that I can now see the diagram also in the plotting perspective. I opened and closed it multiple times, no problem.

I'm using Windows Version 10.0.18363 build 18363.

@ceraolo, build 1909 looks pretty old. Maybe you should run a few system updates?

comment:9 by Adeel Asghar, 4 years ago

I can reproduce the crash now. It is crashing on the close.
Should be fixed with PR#6666.

comment:10 by Adeel Asghar, 4 years ago

Resolution: fixed
Status: reopenedclosed

in reply to:  8 comment:11 by massimo ceraolo, 4 years ago

Replying to casella:

I tried this myself. I confirm that I can now see the diagram also in the plotting perspective. I opened and closed it multiple times, no problem.

I'm using Windows Version 10.0.18363 build 18363.

@ceraolo, build 1909 looks pretty old. Maybe you should run a few system updates?

I'm as updated as I can on all of my PCs.
Indeed, I used "build", which is not the correct name. I should have used "Version" instead.
There are two versions currently on updated win10 PCs. On my desktop, I have the most recent one, i.e #2004.
My laptop has instead the previous one, i.e. 1909. These days Microsoft is releasing 2004 progressively, depending on the hardware installed on a PC. For My latop's hardware, it says win10 is not ready yet to update to 2004.

in reply to:  9 comment:12 by massimo ceraolo, 4 years ago

Replying to adeas31:

I can reproduce the crash now. It is crashing on the close.
Should be fixed with PR#6666.

Great!
I hoped that a crash after so few steps could tell the tale.
Finding crash-causing issues is always a great satisfaction!
I'll check tomorrow.

comment:13 by Francesco Casella, 4 years ago

Very good. It remains a mistery to me why I couldn't reproduce that, but all's well that ends well :)

@ceraolo, please close the ticket yourself if the next nightly no longer has the issue.

in reply to:  13 comment:14 by massimo ceraolo, 4 years ago

Replying to casella:

Very good. It remains a mistery to me why I couldn't reproduce that

Crashes are often erratic.
In some cases, for instance, bugs cause to write to an unallocated area. In this case, the result depends on what is there (I.e. what we overwrite), and this can be different from a PC to another, between runs on the same PC, or even in the same run for the same user action depending on what has been done before.
The ticket is already closed.

Last edited 4 years ago by massimo ceraolo (previous) (diff)
Note: See TracTickets for help on using tickets.