Opened 4 years ago
Last modified 3 years ago
#6071 assigned defect
Don't show parameter edits in FMU created with "Evaluate all parameters"
| Reported by: | massimo ceraolo | Owned by: | Lennart Ochel |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.19.0 |
| Component: | FMI | Version: | v1.16.0-dev |
| Keywords: | Cc: | @… |
Description (last modified by )
When we create an FMU while "Evaluate all parameters" is active, parameter values are hard-coded in the FMU. When we later use the FMU, no trace of this characteristic is there.
Steps to reproduce:
- open FMUissue.mo.
- create a ME FMU from Gain
- load the FMU, open Test and connect the output of realExpression to the FMU input
- simulate: the output is (correctly) constantly equal to 2
- change K from 2 to 4 in the variables Browser => the output does not change to 4. This is because in reality K=2 was hardcoded in the FMU
- go in the modeling perspective, double click on the FMU and change gain1_k from 2 to 4, and simulate => the output is still 2 (again, this is because K=2 is hard-coded in the FMU).
This behaviour, although correct, and clear once one has understood what happens, can be very confusing in the beginning.
I think that when we create FMUs with the option "Evaluate all parameters" active, it should be made impossible to change parameters either from the FMU dialog (before simulating) or from the Variables Browser (before re-simulating). I mean, the edits containing these parameters shud be non-editable.
Attachments (1)
Change History (8)
by , 4 years ago
| Attachment: | FMUissue.mo added |
|---|
comment:1 by , 4 years ago
| Summary: | Don't show parameter edits in FMU created with ealuate all parameters → Don't show parameter edits in FMU created with "Evaluate all parameters" |
|---|
comment:2 by , 4 years ago
| Description: | modified (diff) |
|---|
comment:3 by , 4 years ago
| Component: | *unknown* → FMI |
|---|---|
| Owner: | changed from to |
| Priority: | high → blocker |
| Status: | new → assigned |
comment:4 by , 4 years ago
| Cc: | added |
|---|
Note:
See TracTickets
for help on using tickets.
@lochel, I think this is an important fix for consistency. I guess it is not too difficult. As I understand "Evaluate all parameters" simply sets all parameters as structural in the frontend, so that they all get evaluated.
We should have a consistent framework that only exposes non-structural parameters in the FMI interface. Maybe it is already there and it simply needs to be fixed, I'm not sure.