OMEdit does not render graphical annotations if "closure" annotation is present.

[Dietmar Winkler]

If a graphical annotation contains the closure attribute anywhere then OMEdit will not render the graphic at all. In case of an icon the whole icon is vanishing.

[Adrian Pop]

Anywhere? It should only be part of Ellipse:
​https://specification.modelica.org/v3.4/Ch18.html#ellipse
Do you have an example?

[Dietmar Winkler]

See also ​https://github.com/simulatino/OpenHPL/pull/29/commits/e19e3e7ff4fca0744022ed4c1ded6fb1097abe47 for changes that needed to be done to get OMEdit displaying the icon.

[Dietmar Winkler]

Sorry yes inside Ellipse will stop OMEdit displaying the icon as seen in the above diff. You can use OpenHPL/Icons/BendPipe.mo as an example.

[Francesco Casella]

We should get this fixed in 1.17.0.

@dietmarw, it this is critical for you, e.g. because of use in the classroom, pls. set the milestone to 1.16.1

[Dietmar Winkler]

Replying to casella:

@dietmarw, it this is critical for you, e.g. because of use in the classroom, pls. set the milestone to 1.16.1

That depends on when 1.17.0 is scheduled for and 1.16.1 before that.

[Adrian Pop]

The OMC part should be fixed in: ​https://github.com/OpenModelica/OpenModelica/pull/6739
Seems Modelica Spec 3.4 added this new closure element in Ellipse.

The OMEdit part will be handled by @adeas31.

[Dietmar Winkler]

OK so closure is actually a feature from a "future" spec. But in case similar situations occur it would be good that OMC simply ignores unknown annotations or simply does not display the entity where this occurs. But it should not drop the display of all present graphical annotation entities. Would this be possible?

[Adrian Pop]

Unfortunately it is not possible with the current way of doing things as we are actually doing instantiation of the graphical records and if something is missing or not defined or extra, there will be an error (showed only if -d=nfAPINoise is activated).

I am planning to change this to something more robust to change but it will take a while.

[Adrian Pop]

Wait, OMEdit should only drop the display the Ellipse in this case, everything else that can be instantiated should work fine. If not, then is some sort of bug and I need to have a look.

[Adeel Asghar]

AFAIK the problem is that getIconAnnotation or getDiagramAnnotation returns nothing in such cases.

[Adrian Pop]

Replying to adeas31:

AFAIK the problem is that getIconAnnotation or getDiagramAnnotation returns nothing in such cases.

We need to investigate this. I'll open a new ticket.

[Francesco Casella]

Replying to dietmarw:

That depends on when 1.17.0 is scheduled for and 1.16.1 before that.

1.17.0 is scheduled for end 2020. 1.16.0 should be released anytime soon, and 1.16.1 could follow in October/November with a few critical cherry-picked fixes on top of that if necessary.

[Dietmar Winkler]

OK in that case 1.17.0 is fine. :-)

[Dietmar Winkler]

So when is 1.18.0 scheduled for?

[Adrian Pop]

I have a fix for this since this ticket was opened:

​https://github.com/OpenModelica/OpenModelica/pull/6739

but it only works properly with the new front-end and -d=nfAPI.
I will push this fix in as we will make the NF the default in 1.17.0 omc (is already the default in OMEdit since 1.14).

So this fix will be in 1.17.

[Dietmar Winkler]

So the reschedule was by mistake?

[Adrian Pop]

Not really. The feature freeze for 1.17 is mid November and I guess @casella didn't have too much info about this bug.

[Francesco Casella]

Replying to dietmarw:

So when is 1.18.0 scheduled for?

July 2021, see the roadmap.

I changed this to 1.18.0 by mistake during a batch change related to Buildings library bugs, it should be 1.17.0, sorry about that.

[Francesco Casella]

Rescheduled to 1.18.0