Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#6112 closed defect (fixed)

Corrective for icon generation is not complete

Reported by: gerrer@… Owned by: Adeel Asghar
Priority: high Milestone: 1.16.0
Component: Documentation Version:
Keywords: icon generation Cc:

Description

The corrective of generate_icons.py does not solve all issues of image export.
See the example joined.
Thanks a lot for working on this topic !

Attachments (3)

example.zip (3.1 KB ) - added by gerrer@… 4 years ago.
The original icon and the icon exported by generate_icons.py
export_icon.zip (13.8 KB ) - added by gerrer@… 4 years ago.
The model IconExample, with its two connectors, inside a library.
MyLibrary.IconExample.svg (1.7 KB ) - added by Adeel Asghar 4 years ago.

Download all attachments as: .zip

Change History (9)

by gerrer@…, 4 years ago

Attachment: example.zip added

The original icon and the icon exported by generate_icons.py

comment:1 by Adeel Asghar, 4 years ago

Please share the actual Modelica model for testing.

Note that the script is an icon generator and not the diagram generator. I am guessing that you are trying to export diagram.

by gerrer@…, 4 years ago

Attachment: export_icon.zip added

The model IconExample, with its two connectors, inside a library.

comment:2 by gerrer@…, 4 years ago

Please find attached the Modelica model (a toymodel with no physics).

On the icon view (the one I'm interested in), I want the two connectors to appear. Which happens when I export the icon via OMEdit, and fails when I use the script generate_icons.

Thanks for your feedback.

by Adeel Asghar, 4 years ago

Attachment: MyLibrary.IconExample.svg added

comment:3 by Adeel Asghar, 4 years ago

Works perfectly fine for me. See the attached icon generated using the script.

Note that the script doesn't remove/overwrite the existing icons. Make sure you delete the old icon manually. Also have you updated OMPython?

comment:4 by gerrer@…, 4 years ago

Thanks for highlighting that the script doesn't overwrite the existing icons.

My example model was a bad one.
I tried to reproduce the icon export bug occurring on a model in ThermoSyspro library (ThermoSysPro.WaterSteam.Machines.StodolaTurbine).
Could you maybe check the icon export for this model (the library is opensource)?

Thanks by advance.

comment:5 by Adeel Asghar, 4 years ago

Resolution: fixed
Status: newclosed

Should work fine with 811a6c8/OpenModelica.

comment:6 by gerrer@…, 4 years ago

It does, thanks !

Note: See TracTickets for help on using tickets.