Opened 4 years ago
Last modified 3 years ago
#6118 assigned defect
MSVC does not work with Cpp runtime under Windows
| Reported by: | Rüdiger Franke | Owned by: | |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.19.0 |
| Component: | Build Environment | Version: | v1.16.0-dev |
| Keywords: | Cc: | Adrian Pop |
Description
Selecting msvc15 in OMEdit under Windows, the compilation fails do to spaces in the *.makefile:
include C:/Program Files (x86)/OpenModelica1.16.0-dev-32bit/include/omc/cpp/ModelicaConfig_msvc.inc include C:/Program Files (x86)/OpenModelica1.16.0-dev-32bit/include/omc/cpp/ModelicaLibraryConfig_msvc.inc
Attempting to fix the spaces and call Compile.bat manually, the compilation continues to fail, then with syntax error for !IF.
Selecting MinGW, the respective includes become:
include $(OMHOME)/include/omc/omsicpp/ModelicaConfig_gcc.inc include $(OMHOME)/include/omc/omsicpp/ModelicaLibraryConfig_gcc.inc
Why omsicpp and not cpp -- it seems to work though?
Change History (11)
comment:1 by , 4 years ago
| Cc: | added |
|---|
comment:2 by , 4 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:3 by , 4 years ago
comment:4 by , 4 years ago
Forget the syntax errors. They seem to be related to proper installation of msvc. But the wrong paths remain.
comment:5 by , 4 years ago
See PR https://github.com/OpenModelica/OpenModelica/pull/6775 for the wrong paths.
We discussed this in today's meeting but since Niklas and Rudiger were not there so decided to schedule it for later meeting.
Basically I looked through the code and there is a mess.
- We have files like
CodegenCpp.tpl,CodegenCppOld.tpl,CodegenOMSICpp.tpl. We need to clean the code. - The
omsicandomsicpptargets are not use so should be removed from OMEdit. - The
msvclibs folder is missing incppfolder.
comment:6 by , 4 years ago
The omsicpp target is used and also the templates CodegenCpp.tpl, CodegenCppOld.tpl, CodegenOMSICpp.tpl so please do not change that. Adrian introduced the new template CodegenCppOld.tpl to continue using the cpp runtime folder with the simcode target cpp .
The template CodegenOMSICpp.tpl is used by the simcode target omsicpp which is needed for us.
comment:7 by , 4 years ago
| Owner: | removed |
|---|
The include paths are fixed. See 8b14eeb/OpenModelica.
One remaining issue is that msvc binaries folder is missing.
After discussion during today's devmeeting, @adeas31 will have a look at that.