Opened 3 years ago

Closed 3 years ago

#6239 closed defect (fixed)

Invalid error message from OM

Reported by: ceraolo Owned by: adeas31
Priority: critical Milestone: 1.16.2
Component: OMEdit Version: v1.17.0-dev
Keywords: Cc:

Description

Steps to reproduce:

  • load omEdit
  • load Test.mo
  • Change Amplitude of sine wave in E1 to 101
  • Change Amplitude of sine wave in E1 to 100

The following error message appears:

[3] 10:07:51 Syntax Error
[: 1:0-1:0]: No viable alternative near token: <EOF>

However, the code is ok and simulates well.
(report by my student Vannuccini)

Attachments (3)

Test.mo (2.4 KB) - added by ceraolo 3 years ago.
Settings.pdf (299.3 KB) - added by ceraolo 3 years ago.
omeditcommunication.log (3.2 MB) - added by ceraolo 3 years ago.

Change History (21)

Changed 3 years ago by ceraolo

comment:1 Changed 3 years ago by adrpo

I can't reproduce this with a bit older OMEdit, I will compile a new one.

comment:2 Changed 3 years ago by ceraolo

We did this with 1.17.0-dev-141

comment:3 follow-up: Changed 3 years ago by casella

@ceraolo, I tried with the latest nightly build v1.17.0-dev-195-g637d5adedc, I can't reproduce this either. Would you mind trying that out?

comment:4 Changed 3 years ago by ceraolo

I will tomorrow

comment:5 follow-up: Changed 3 years ago by casella

@ceraolo, if some of your students spot issues, you can put their email in the cc: field of the ticket, so they can get and provide feedback faster.

comment:6 in reply to: ↑ 5 Changed 3 years ago by ceraolo

Replying to casella:

@ceraolo, if some of your students spot issues, you can put their email in the cc: field of the ticket, so they can get and provide feedback faster.

I grant them marks if they found replicable issues.
They are at their first experiences with OM, and are not ready for trac: I tried what you mention two years ago with poor results.

Last edited 3 years ago by ceraolo (previous) (diff)

comment:7 in reply to: ↑ 3 Changed 3 years ago by ceraolo

Replying to casella:

@ceraolo, I tried with the latest nightly build v1.17.0-dev-195-g637d5adedc, I can't reproduce this either. Would you mind trying that out?

I downloaded and run dev-195 and got exactly the same issue.
I made all tests under Windows 64 bit.

Consider that the same issue was observed on three different PC's (the student's and two of mine)

Last edited 3 years ago by ceraolo (previous) (diff)

comment:8 follow-ups: Changed 3 years ago by adeas31

I also can't reproduce this.

@ceraolo did you make the change via the GUI or in the text view? I tried all combinations. Changing amplitude of all SineVoltages from parameters window and from text view and none produced that error.

comment:9 in reply to: ↑ 8 Changed 3 years ago by casella

Replying to adeas31:

I also can't reproduce this.

Me neither.

Do you have some particular setting that you recommend to your students?

@adeas31, is there any file we can get from @ceraolo which contains all the OMEdit settings?

comment:10 Changed 3 years ago by ceraolo

I enclose the settings we use (OMedit settings.pdf), with evidence given to some differences from the default. I suppose there are no differences from default outside the shown pictures. I enclose the log as well.

Last edited 3 years ago by ceraolo (previous) (diff)

Changed 3 years ago by ceraolo

Changed 3 years ago by ceraolo

comment:11 in reply to: ↑ 8 Changed 3 years ago by ceraolo

Replying to adeas31:

I also can't reproduce this.

@ceraolo did you make the change via the GUI or in the text view? I tried all combinations. Changing amplitude of all SineVoltages from parameters window and from text view and none produced that error.

Did the changes via GUI (parameters window)

comment:12 Changed 3 years ago by adeas31

Ah now I see why this is happening.

Enable replaceable support and you won't see the error. I will fix this.

comment:13 Changed 3 years ago by adeas31

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in ebd255f/OpenModelica and ported to 1.16

comment:14 follow-up: Changed 3 years ago by casella

  • Milestone changed from 1.17.0 to 1.16.2
  • Priority changed from normal to critical

What has replaceable support to do with changing a parameter value?

comment:15 follow-up: Changed 3 years ago by casella

  • Resolution fixed deleted
  • Status changed from closed to reopened

I'll keep this open until we release 1.16.2 or 1.17.0.

comment:16 in reply to: ↑ 14 Changed 3 years ago by adrpo

Replying to casella:

What has replaceable support to do with changing a parameter value?

We based *some* of the new changes on the "replaceable" prefix of the component or class which was true even for some replaceable components. So some of the new parts were ran even if the replaceable support flag was not activated which generated this error.

Now all the new parts are guarded with the replaceable support flag.

comment:17 Changed 3 years ago by casella

ok, thanks!

comment:18 in reply to: ↑ 15 Changed 3 years ago by casella

  • Resolution set to fixed
  • Status changed from reopened to closed

Replying to casella:

I'll keep this open until we release 1.16.2 or 1.17.0.

Sorry, this was stupid, we always close the ticket when the fix is comitted to the corresponding version branch.

Note: See TracTickets for help on using tickets.