ThermalSeparation not working

[Rüdiger Franke]

The commits at ​https://github.com/thom-marx/ThermalSeparation indicate some contributions by OpenModelica developers. However, all examples are rejected by OpenModelica with a message of the kind:

[ThermalSeparation.Media.WaterBasedLiquid.BaseClasses: 25:3-32:30]:
PartialMedium is partial, name lookup is not allowed in partial classes.

Can this be fixed?

[Per Östlund]

The error messages are entirely correct in this case, so the library needs to be fixed in that case. But that particular issue is not trivial to fix, so it needs someone who actually knows something about the library to have a look.

[Francesco Casella]

@rfranke, in some cases some classes (e.g. type declarations) are taken from partial packages. It is necessary to take them from non-partial (possibly redeclared) packages instead, because lookup in partial classes is not allowed in simulation models.

For more information, see the corresponding section in ​User's Guide. In the same chapter of the guide there are other indications on how to make sure that libraries are fully compliant to the Modelica specification, so they can be used in OMC.

[Rüdiger Franke]

Well, if partial qualifiers limit the lookup, then one might remove them. Unfortunately it does still not work. Instead the error message changes to:

Internal Error Instantiation of ThermalSeparation.Examples.Absorption_IdealGases failed with no error message.

Another observation: Open OMEdit 1.16.2, load the original ThermalSeparation library that comes with OpenModelica and simulate Examples.Absorption_IdealGases. Click on the error message as given in the ticket opener.
OMEdit will disappear (stack overflow?).

Alternatively: Open OMEdit 1.16.2, load the original ThermalSeparation library that comes with OpenModelica. Browse to ThermalSeparation.Media.WaterBasedLiquid -- three clicks.
OMEdit will disappear (stack overflow?).

Not good for a library found in quite some publications and running well with other Modelica tools.

[Francesco Casella]

Replying to rfranke:

Well, if partial qualifiers limit the lookup, then one might remove them.

Could you open a PR on the ​library repository with that fix? This would allow us to go forward with the analysis.

Unfortunately it does still not work. Instead the error message changes to:

Internal Error Instantiation of ThermalSeparation.Examples.Absorption_IdealGases failed with no error message.

Another observation: Open OMEdit 1.16.2, load the original ThermalSeparation library that comes with OpenModelica and simulate Examples.Absorption_IdealGases. Click on the error message as given in the ticket opener.
OMEdit will disappear (stack overflow?).

This of course shouldn't happen.

Alternatively: Open OMEdit 1.16.2, load the original ThermalSeparation library that comes with OpenModelica.

Shipping libraries with OpenModelica was not a good idea IMHO. It conveys the impression that we are somehow supporting or endorsing them, even when it is not really the case. From 1.17.0 there will be no shipped libraries, you will use the package manager to download them, and if you do it, it's at your own risk.

Browse to ThermalSeparation.Media.WaterBasedLiquid -- three clicks.
OMEdit will disappear (stack overflow?).

This is also not good.

Not good for a library found in quite some publications and running well with other Modelica tools.

@rfranke, getting all OS libraries to work 100% in OpenModelica is a massive endevour, which requires to both fix the libraries and fix OpenModelica. We are already doing it for some libraries that are of interest for OSMC members, but we have to prioritize.

Is this library interesting for ABB? If so, we can prioritize it.

I cc: Thomas Marx-Schubach and Gerhard Schmitz from TUHH, I'm not sure if he is still actively developing it. I understood from Gerhard that research on CO2 capture is dead in Germany for the time being.

[Francesco Casella]

Ticket retargeted after milestone closed