Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#6406 closed defect (fixed)

OMEdit GUI not working properly

Reported by: ilhan.yildirim@… Owned by: Adrian Pop
Priority: blocker Milestone: 1.17.0
Component: OMEdit Version: v1.17.0-dev
Keywords: Cc: Adeel Asghar

Description

Hello,

I have been using OM for some benchmark projects for a while and testing it for custom analyses of mainly 1D thermo-fluid systems. Recently, I came across some GUI problems which I will be summarize below.

I have installed recent version of v1.17.0-dev.beta3 (64-bit) in Win10 wint MSL 4.0.0.

1) Default installation settings are shown in screenshot Cap1.
2) View of Modelica.Fluid.Examples.HeatExchanger.HeatExchangerSimulation: Screenshot Cap2
3) View of Parameters window of the above example: Cap3
4) View of Initialization window of the above example: Cap4

I have enabled the Replaceable Support and restarted OMEdit (Cap1A). I opened the above example (Cap2A).

The issue that I noticed are:
1) Opening of the Parameters window took some time. May be 10-15 seconds. When opened parameters that appear on GUI showed in one window without any tabs or groups (Cap3A).

2) Closed the example tried to open again and during long opening time I closed the OMEdit. Then reopened the HEX example and now the view is as in Cap2B.

I am not sure if these issues can be reproduced or related to my computer settings etc.

Regards,
Ilhan

Attachments (8)

Cap1.PNG (158.0 KB ) - added by ilhan.yildirim@… 4 years ago.
Cap2.PNG (135.4 KB ) - added by ilhan.yildirim@… 4 years ago.
Cap3.PNG (133.7 KB ) - added by ilhan.yildirim@… 4 years ago.
Cap4.PNG (131.8 KB ) - added by ilhan.yildirim@… 4 years ago.
Cap1A.PNG (168.5 KB ) - added by ilhan.yildirim@… 4 years ago.
Cap2A.PNG (134.7 KB ) - added by ilhan.yildirim@… 4 years ago.
Cap3A.PNG (123.3 KB ) - added by ilhan.yildirim@… 4 years ago.
Cap2B.PNG (128.7 KB ) - added by ilhan.yildirim@… 4 years ago.

Download all attachments as: .zip

Change History (19)

by ilhan.yildirim@…, 4 years ago

Attachment: Cap1.PNG added

by ilhan.yildirim@…, 4 years ago

Attachment: Cap2.PNG added

by ilhan.yildirim@…, 4 years ago

Attachment: Cap3.PNG added

by ilhan.yildirim@…, 4 years ago

Attachment: Cap4.PNG added

by ilhan.yildirim@…, 4 years ago

Attachment: Cap1A.PNG added

comment:1 by ilhan.yildirim@…, 4 years ago

I will upload the rest of the screenshots when Trac allows me to and quits thinking they are spam :)

BR,
Ilhan

comment:2 by Adrian Pop, 4 years ago

Please try again, I trained the spam filter with your files. Sorry about that.

by ilhan.yildirim@…, 4 years ago

Attachment: Cap2A.PNG added

by ilhan.yildirim@…, 4 years ago

Attachment: Cap3A.PNG added

by ilhan.yildirim@…, 4 years ago

Attachment: Cap2B.PNG added

in reply to:  2 comment:3 by ilhan.yildirim@…, 4 years ago

Replying to adrpo:

Please try again, I trained the spam filter with your files. Sorry about that.

Thanks @adrpo. I have uploaded them.

comment:4 by Francesco Casella, 4 years ago

Cc: Adeel Asghar added
Milestone: NeedsInput1.17.0
Owner: changed from Adeel Asghar to Adrian Pop
Priority: highblocker
Status: newassigned

@adrpo, I tried this myself with beta3 on my Windows 10 PC. If I have Enable Replaceable Support turned off, but new frontend API turned on, I see gray boxes instead of the pump icons, but at least I see the connectors on HEX.

If I also activate Enable Replaceable Support, the four connectors of HEX are no longer visible.

It seems we're still not there. This has top priority for 1.17.0.

comment:5 by Adrian Pop, 4 years ago

The problem seems to be in MSL 4.0.0 which has *BAD BAD BAD* annotations. For example:
https://github.com/modelica/ModelicaStandardLibrary/blob/master/Modelica/Fluid/Examples/HeatExchanger.mo
has annotation(choicesAllMatching, ...) but the Modelica specification says that the annotation should be: choicesAllMatching=true.
https://specification.modelica.org/maint/3.5/inheritance-modification-and-redeclaration.html#annotation-choices-for-suggested-redeclarations-and-modifications

comment:6 by Adrian Pop, 4 years ago

The PR: https://github.com/modelica/ModelicaStandardLibrary/pull/3779 will fix the bad annotations in MSL. This will fix the issue with dialogs not having tabs.

There are other issues with this ticket, I will instigate more. As far as I can tell a the moment some parameters showing up in graphical annotations are not evaluated to literals and OMEdit has no clue what to do with them so it fails to display the icons.

Last edited 4 years ago by Adrian Pop (previous) (diff)

comment:7 by Adrian Pop, 4 years ago

PR: https://github.com/OpenModelica/OpenModelica/pull/7310 should fix all the icon display issues.

comment:8 by Adrian Pop, 4 years ago

Will port the fixes to 1.17 and close this.

comment:10 by Adrian Pop, 4 years ago

Resolution: fixed
Status: assignedclosed

comment:11 by Francesco Casella, 4 years ago

Great! Ready to release 1.17.0

Last edited 4 years ago by Francesco Casella (previous) (diff)
Note: See TracTickets for help on using tickets.