OMEdit crashes when loading the BRSL and instantiating a library item

[Niklas Worschech]

If you load the BRSL in OMEdit and expand an element in the library explorer, OMEdit crashes. e.g.

• Load BRSL\Rexroth_Generic\package.mo
• Expand Rexroth_Generic.Hydraulics.Examples in the library browser
• double click InitializationConcept

[Francesco Casella]

Let's target this for the 1.17.1 bugfix release.

@adeas31, can you please make a first assessment of what is going wrong?

[Adrian Pop]

I could not reproduce this myself with (almost) the latest master. I will recompile and try again.

@niklwors: can you attach your OMEdit settings file: %APPDATA%\openmodelica\omedit.ini
so that we can see if you are using some bad settings. You can zip it with the same password that you used for the libs.

[Niklas Worschech]

@adrpo sorry I used 1.16.5, but this version is not availible in the drop down list.
I have attached my file.

[Niklas Worschech]

omedit version

[Adrian Pop]

I added the version so we can properly report bugs for that version.

[Adrian Pop]

I tried with v1.16.5 also and still get no crash. Will look into your settings a bit now.

[Niklas Worschech]

@adrpo I have reinstalled OpenModelica 1.16.5 and now it works. I have tested it serveral times and it always worked. I'm sorry I dont know what the problem was, but then we can close the ticket.

[Francesco Casella]

All's well that ends well :)

[Adrian Pop]

In the meantime @niklwors sent via email: "I uninstalled now 1.16.5 and installed 1.17 beta and then it crashes again. But after I restarted OMEdit it works. Is this maybe an installation problem?"

[Adrian Pop]

@adeas31, maybe OMEdit doesn't properly read the settings on first run when you switch versions?

[Adeel Asghar]

I will test it once the Windows servers are up again.

[Adeel Asghar]

I finally managed to test this a bit. The problem is Enable Replaceable Support *. It crashes if you have not enabled it before loading the library and then enable it and try to open the library diagram.

Note the asterisk next to the flag. This indicates that you need to restart after setting this flag. OMEdit somehow end up in weird state if enable/disable of this flag is mixed in one session.

[Adeel Asghar]

I also noticed the same in the log sent by Sven. His log file shows that the library is loaded first and then replaceable support is enabled.

[Adeel Asghar]

Here is the combination for the crash.

1. Uncheck Enable Replaceable Support
2. Close OMEdit
3. Start OMEdit
4. Load BRSL
5. Check Enable Replaceable Support
6. Expand Rexroth_Generic.Hydraulics.Examples in the library browser
7. double click InitializationConcept

[Francesco Casella]

Replying to adeas31:

I finally managed to test this a bit. The problem is Enable Replaceable Support *. It crashes if you have not enabled it before loading the library and then enable it and try to open the library diagram.

Note the asterisk next to the flag. This indicates that you need to restart after setting this flag.

What about detecting that change and suggesting the user to quit OMedit once OK is pressed?

[Adeel Asghar]

Maybe. The thing is this is more like a new feature rather than a bug fix so we shouldn't do this for 1.17 and on the other hand perhaps in 1.18 we don't need this flag and have this enabled by default.

[Francesco Casella]

Replying to adeas31:

Maybe. The thing is this is more like a new feature rather than a bug fix so we shouldn't do this for 1.17 and on the other hand perhaps in 1.18 we don't need this flag and have this enabled by default.

Agreed. I hope they won't be necessary anymore.

[Francesco Casella]

This looks to be fixed in 1.18.0