Opened 4 years ago

Closed 4 years ago

#6427 closed defect (fixed)

MSL 4.0 dialog is shown even if MSL 4.0 is not installed

Reported by: anonymous Owned by: Francesco Casella
Priority: blocker Milestone: 1.17.0
Component: OMEdit Version: 1.18.0-dev
Keywords: Cc: Martin Sjölund, Adrian Pop

Description

OMEdit on startup (at least on Linux) shows a dialog asking the user to either load the Modelica standard library version 3.2.3 or 4.0.0, regardless of whether the MSL 4.0 has been installed through the package manger or not.

If the user selects MSL 4.0, then OMEdit complains it can't find it. Closing and reopening OMedit no longer opens any dialog, and the user is left with an OMEdit that keeps failing to load the MSL 4.0 and can't use the MSL.

I could fix it by manually installing the MSL 4.0, but less knowledgeable users may not fix it so easily.

Change History (10)

comment:1 by Francesco Casella, 4 years ago

Milestone: → 1.17.0

comment:2 by Francesco Casella, 4 years ago

Priority: high → blocker

comment:3 by Adeel Asghar, 4 years ago

Cc: Martin Sjölund Adrian Pop added

No, why did you make this a blocker? We should close this with won't fix.

Remember this was my only concern when we discussed to implement this. And then you suggested to write a detailed description about it so we have this text already,

On Windows, both versions of the MSL are installed automatically by the installer. On Linux, follow the instructions on the ​OpenModelica download page.

in reply to:  3 comment:4 by Francesco Casella, 4 years ago

Replying to adeas31:

No, why did you make this a blocker?

So that I don't forget about it.

We should close this with won't fix.

Remember this was my only concern when we discussed to implement this. And then you suggested to write a detailed description about it so we have this text already,

On Windows, both versions of the MSL are installed automatically by the installer. On Linux, follow the instructions on the ​OpenModelica download page.

I'm going to make that text more explicit. I know reading instructions is hard, let's try to be friendly :)

I'll take care of this myself.

Last edited 4 years ago by Francesco Casella (previous) (diff)

comment:5 by Francesco Casella, 4 years ago

Owner: changed from Adeel Asghar to Francesco Casella
Status: new → assigned

comment:6 by Francesco Casella, 4 years ago

See ​PR 7306 for master and ​PR 7307 for maintenance/v1.17.

The former is merged in already, the latter unfortunately failed, I really have no clue why. I only changed some text in the splash screen, and I got a failure with some homotopy test.

@adeas31, can you please check?

Last edited 4 years ago by Francesco Casella (previous) (diff)

comment:7 by Francesco Casella, 4 years ago

I re-ran the test, maybe it was just a glitch...

comment:8 by Adeel Asghar, 4 years ago

Yes the Qt tests fix is not ported to 1.17 so it fails sometimes. And there is no need to port it since its just for development.

comment:9 by Francesco Casella, 4 years ago

OK, I'll just keep pushing until it passes then :)

Last edited 4 years ago by Francesco Casella (previous) (diff)

comment:10 by Francesco Casella, 4 years ago

Resolution: → fixed
Status: assigned → closed

PRs merged in.

Note: See TracTickets for help on using tickets.