Reinit of non-state variables

[sjoelund.se]

The following model is accepted by OpenModelica, but should not:

model M
  Real r = time;
equation
  when sample(0,0.1) then
    reinit(r, 2*time);
  end when;
end M;

The appropriate error should be:
Cannot use reinit() on r as it cannot be selected as a state variable

[lochel]

look also for #51. There is reinit used in a when initial() clause:

when initial() then
  reinit(x, u);
end when;

That makes no sense and is not valid. Perhaps, that should be caught in the Frontend?

[adrpo]

We might catch the reinint in when initial in the front-end.
I'll see if i can add this rule to the already existing ones.

[lochel]

Nice. You can recover the test case from #51. I have already removed it (r14242) from the testsuite/simulation, because it is no simulation test case.

[adrpo]

I opened a new bug about the reinit in when with
condition initial: #1972 so we can talk about this
more.