Reinit in when equations with condition initial() should report an error

[Adrian Pop]

From Lennart (lochel) comment on bug #1688:
reinit used in a when initial() clause:

when initial() then
  reinit(x, u);
end when;

That makes no sense and is not valid.
Perhaps, that should be caught in the Frontend?

[Adrian Pop]

The question is if this really makes no sense.

Say you load "u" from a file table in an initial
equation or algorithm and then in when initial()
you set "x" to it.

[anonymous]

in such y case you can with:

when initial() then
  x = u;
end when;

The problem is that initial() does not generate an event.

[Adrian Pop]

Ok. I'll already started to add the check. I'll continue.

[Adrian Pop]

Fixed in r14246 and r14247 and r14250 ...
Lots or revisions to get it right :)

[Adrian Pop]

Incredible how many occurrences of this when initial() then reinit we had in the testsuite :)
The same model several times with some differences.

[Lennart Ochel]

Here goes something wrong. It is not possible to replace or even convert a reinit into an assignment. If that were possible, there were no reinit at all.
If you would like to assign some value to a state, use an initial equation/algorithm or binding. In facts, when initial() is not the same as an initial equation/algorithm.
However, good to see that we can already caught these fals statements in the frontend.