Inconsistent interface for instantiation and checking in OMEdit

[Per Östlund]

When instantiating a model in OMEdit a window is displayed that either shows the flattened model or tells the user that instantiation failed. Any error messages are shown in the message list.

When checking a model, the user instead gets a windows with all of the checking information, including any error messages. These messages are not shown in the message list.

I would prefer that if either instantiation or checking fails OMEdit just displays a simple dialog window informing the user of this, and tells the user to look at the message list for the reason why. It doesn't need to be a window with a text box in it, a simple dialog window is enough and looks better. If either command succeeds it can show either the flattened model or the result of the check, without any messages. Regardless of if either command succeeds or not, any messages should be displayed in the message list only. This is just my opinion, the important thing is that the interface is consistent.

[Martin Sjölund]

Postponed until 1.9.1

[Martin Sjölund]

This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).

[Adeel Asghar]

Fixed in r23174.

I can't show errors in messages list because checkModel either returns check status or error message and doesn't set errors for getErrorString. So I have changed instantiateModel to show either flattened model or error message. In short, for both check & instantiate a box will appear with either error message or correct results.

[Martin Sjölund]

You could change checkModel to not be totally annoying, and force getErrorString() to show the message. Then everything could show errors with the messages.