OMEdit has issues when opening files with special chars in them ...

[Adrian Pop]

The file in c:/tö/ö/ägg/åter/file.mo will not be
open and no error message will be given by OMEdit.

It might be an omc issue and not an OMEdit issue.

[Adrian Pop]

Ok, this seems to be an issue with omc.

adrpo@ida-liu050 ~/dev/OMTesting
$ ~/dev/OpenModelica/build/bin/omc +locale=C martin\366/Aufgabe1b.mo 
Error processing file: martinö/Aufgabe1b.mo
Error: iconv("martinö/Aufgabe1b.mo",to="UTF-8",from="UTF-8") failed: Illegal byte sequence

# Error encountered! Exiting...
# Please check the error message and the flags.

Execution failed!

[Martin Sjölund]

Uhmmm... You are sending an ISO-8859-1 ö... It works fine in a UTF-8 terminal:

$ omc +locale=C martinö/abc.mo 
/home/marsj/dev/trunk/build/bin/omc 1.9.0 Beta1 (r13118)
class M
end M;

If you have a non-UTF8 filesystem you need to add character conversion calls for this! I will add a check to verify that all flags sent to the compiler are in UTF-8.

[Martin Sjölund]

No more omc issue :D

[Adeel Asghar]

No, its still an omc issue but maybe only on Windows. Its better to fix it in omc rather than handling it in all clients since its the loadFile command that's failing.

[Martin Sjölund]

I believe it's not loadFile, but rather parsing the input string. Like this session in OMShell-terminal:

>>> "åäö"
"åäö"
>>> getErrorString()
""
# Changing terminal encoding to ISO-8859-1 here.
>>> "åäö"
Error occured building AST
Syntax Error
[<interactive>:1:0-1:3:writable] Error: The file was not encoded in UTF-8:
  "???".
  To change encoding when loading a file: loadFile(encoding="ISO-XXXX-YY").
  To change it in a package: add a file package.encoding at the top-level.
  Note: The Modelica Language Specification only allows files encoded in UTF-8.

[Martin Sjölund]

So you need to change it to send a UTF-8 string in clients. Come on, everything is UTF-8 :) After that, we can look into making it convert filenames to Windows encoding when on Windows.

[Martin Sjölund]

Postponed until 1.9.1

[Martin Sjölund]

This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).

[Adrian Pop]

This is ugly but we need to use the wide char API in Windows (which supports UTF16).

[Martin Sjölund]

Milestone changed to 1.9.3 since 1.9.2 was released.

[Martin Sjölund]

Moved to new milestone 1.9.4

[Martin Sjölund]

Milestone pushed to 1.9.5

[Martin Sjölund]

Milestone renamed

[Martin Sjölund]

Ticket retargeted after milestone closed

[Martin Sjölund]

Milestone moved to 1.12.0 due to 1.11.0 already being released.

[Francesco Casella]

Rescheduled to 1.14.0 after 1.13.0 releasee

[Adeel Asghar]

This has been fixed in some recent commits.