Opened 12 years ago

Last modified 3 years ago

#2132 assigned defect

getComponentAnnotations should evaluate the parameters

Reported by: Adeel Asghar Owned by: Adrian Pop
Priority: blocker Milestone: 1.19.0
Component: Interactive Environment Version: trunk
Keywords: Cc: Francesco Casella, Martin Sjölund, Per Östlund

Description

getComponentAnnotations should evaluate the parameters inside the annotations and return the correct annotations result.

For example,

loadModel(Modelica)
getComponentAnnotations(Modelica.Mechanics.MultiBody.World)
true
{{Placement(true,0.0,0.0,84.0,-16.0,116.0,16.0,0.0,0.0,0.0,-,-,-,-,0.0)},{},{Dialog(error)},{Dialog(error)},{},{},{},{Dialog(error)},{},{Dialog(error)},{},{Dialog(error)},{Dialog(error)},{Dialog(error)},{Dialog(error)},{Dialog(error)},{Dialog(error)},{Dialog(error)},{Dialog(error)},{Dialog(error)},{Dialog(error)},{Dialog(error)},{Dialog(error)},{Dialog("Defaults","Parameters",true,false,"",false)},{Dialog("Defaults","Parameters",true,false,"",false)},{Dialog("Defaults","Parameters",true,false,"",false)},{Dialog("Defaults","Parameters",true,false,"",false)},{Dialog("Defaults","Parameters",true,false,"",false)},{Dialog("Defaults","Parameters",true,false,"",false)},{Dialog("Defaults","Parameters",true,false,"",false)},{Dialog("Defaults","Parameters",true,false,"",false)},{Dialog("Defaults","Parameters",true,false,"",false)},{Dialog("Defaults","Parameters",true,false,"",false)},{Dialog("Defaults","Parameters",true,false,"",false)},{Dialog("Defaults","Parameters",true,false,"",false)},{Dialog("Defaults","Parameters",true,false,"",false)},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{}}

Change History (19)

comment:1 by Francesco Casella, 12 years ago

Priority: highcritical

This functionaly is require in order to get the correct results for the GUI in the case of models with conditional connectors, which is crucial in order to get a meaningful rendering of the MSL in OMEdit. It is also useful for the Enable annotation, which is often used in MSL to help the end user setting only those parameters that make sense to set. The lack of support for such functionality might lead to a very confusing appearance of many models in the MSL, whose interface was designed with such features in mind.

I would then recommend to fix it with high priority, as all the infrastructure in OMEdit is now ready to handle this correctly.

comment:2 by Martin Sjölund, 11 years ago

Milestone: 1.9.01.9.1

Postponed until 1.9.1

comment:3 by Martin Sjölund, 10 years ago

Milestone: 1.9.11.9.2

This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).

comment:4 by Martin Sjölund, 10 years ago

Milestone: 1.9.21.9.3

Milestone changed to 1.9.3 since 1.9.2 was released.

comment:5 by Martin Sjölund, 9 years ago

Milestone: 1.9.31.9.4

Moved to new milestone 1.9.4

comment:6 by Adeel Asghar, 9 years ago

Cc: Martin Sjölund Per Östlund added
Owner: changed from somebody to Adrian Pop
Status: newassigned

The same behavior is experienced when the code contains some tool specific annotations. See #3655.

comment:7 by Martin Sjölund, 9 years ago

Milestone: 1.9.41.9.5

Milestone pushed to 1.9.5

comment:8 by Martin Sjölund, 9 years ago

Milestone: 1.9.51.10.0

Milestone renamed

comment:9 by Martin Sjölund, 8 years ago

Milestone: 1.10.01.11.0

Ticket retargeted after milestone closed

comment:10 by Martin Sjölund, 8 years ago

Milestone: 1.11.01.12.0

Milestone moved to 1.12.0 due to 1.11.0 already being released.

comment:11 by Francesco Casella, 7 years ago

Milestone: 1.12.01.13.0
Priority: criticalblocker

I guess it's finally time to address this.

@adrpo, can we have this in 1.13.0 together with replaceable support? Otherwise, please change the milestone to 2.0.0

comment:12 by Francesco Casella, 6 years ago

Milestone: 1.13.01.14.0

Will implement this in 1.14.0, once the new-front-end-based API is stable.

comment:13 by Francesco Casella, 6 years ago

See #2081, I guess it's basically the same issue

comment:14 by Francesco Casella, 5 years ago

Milestone: 1.14.01.15.0

Releasing 1.14.0 which is stable and has many improvements w.r.t. 1.13.2.

This issue, previously marked as blocker for 1.14.0, is rescheduled to 1.15.0

comment:15 by Francesco Casella, 5 years ago

Milestone: 1.15.01.16.0

Release 1.15.0 was scrapped, because replaceable support eventually turned out to be more easily implemented in 1.16.0. Hence, all 1.15.0 tickets are rescheduled to 1.16.0

comment:16 by Francesco Casella, 4 years ago

Milestone: 1.16.01.17.0

Retargeted to 1.17.0 after 1.16.0 release

comment:17 by Francesco Casella, 4 years ago

Milestone: 1.17.01.18.0

Rescheduled to 1.18.0

comment:18 by Francesco Casella, 3 years ago

Milestone: 1.18.0

Ticket retargeted after milestone closed

comment:19 by Francesco Casella, 3 years ago

Milestone: 1.19.0

1.18.0 blocker tickets moved to 1.19.0

Note: See TracTickets for help on using tickets.