Opened 12 years ago

Closed 11 years ago

#2255 closed enhancement (fixed)

Units in plot windows are missing

Reported by: dr.christian.kral@… Owned by: Adeel Asghar
Priority: normal Milestone: 1.9.1
Component: OMEdit Version: trunk
Keywords: plot units result Cc:

Description

When generating a plot from a simulation experiment, none of the displayed variables is labeled with a unit. I attached an example plot of Modelica.Electrical.Machines.Examples.AsynchronousInductionMachines.AIMC_DOL to demonstrate the missing units. Time variable is missing (s), i.e., seconds, and torque is missing (N.m), i.e., Newton.meters.

Being a scientist I think that showing a numerical result of a physical variable always requires to have units displayed. Otherwise the result(s) cannot be interpreted unambiguously. Assuming coherent SI units is not sufficient on my opinion.

Attachments (2)

units_missing_in_plot_window.png (18.2 KB ) - added by dr.christian.kral@… 12 years ago.
Result plot
degC.png (8.6 KB ) - added by christiankral <dr.christian.kral@…> 11 years ago.
Celsius temperatures are displayed instead of Kelvin temperature

Download all attachments as: .zip

Change History (11)

by dr.christian.kral@…, 12 years ago

Result plot

comment:1 by Martin Sjölund, 11 years ago

Milestone: 1.9.01.9.1

Postponed until 1.9.1

comment:2 by Adeel Asghar, 11 years ago

Resolution: fixed
Status: newclosed

Fixed in r18075.

comment:3 by dr.christian.kral@…, 11 years ago

I am glad do see units, values and descriptions added to the variable browser in the Simulation window. This is a great improvement. Additionally, the units in the plotted graph (see previously attached PNG file) are not shown. The time axis is labeled with Time but not Time (s). Plot of torque is labeled aimc.tauElectrical but not aimc.tauElectrical (Nm).

comment:4 by Adeel Asghar, 11 years ago

Ah, this is also possible. But I have to re-structure some of the code to do this. Right now there is no time to add this enhancement. Perhaps I will add it when I get some time.

comment:5 by Christian Kral <dr.christian.kral@…>, 11 years ago

Resolution: fixed
Status: closedreopened

Thanks for considering units in the plot window.

comment:6 by christiankral <dr.christian.kral@…>, 11 years ago

I found a bug in displaying (Kelvin) temperatures. Kelvin temperatures are displayed with unit degC in the variable browser. The bug applies to r20609.

by christiankral <dr.christian.kral@…>, 11 years ago

Attachment: degC.png added

Celsius temperatures are displayed instead of Kelvin temperature

comment:7 by Adeel Asghar, 11 years ago

Can you provide a sample model? This data is read from an XML-file. I think the bug is when we are writing the XML file.

in reply to:  6 comment:8 by Adeel Asghar, 11 years ago

Replying to christiankral <dr.christian.kral@…>:

I found a bug in displaying (Kelvin) temperatures. Kelvin temperatures are displayed with unit degC in the variable browser. The bug applies to r20609.

Fixed in r21153.

comment:9 by Adeel Asghar, 11 years ago

Resolution: fixed
Status: reopenedclosed

Units are now shown in plot windows as well.
Done in r21182.

Note: See TracTickets for help on using tickets.