Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#2256 closed defect (fixed)

Disable interactive button

Reported by: Martin Sjölund Owned by: Adeel Asghar
Priority: high Milestone: 1.9.0
Component: OMEdit Version: trunk
Keywords: Cc: Willi Braun

Description

The interactive simulation button is shadowed out on the current builds, which is bad (it suggests it is possible to do interactive simulations).

Also, on OSX the tab is not even shadowed out!

Change History (13)

comment:1 by Adeel Asghar, 12 years ago

The tab is disabled. MainWindow.cpp:193.

It could be the Qt issue. I can't do anything else to make is disable.

comment:2 by Martin Sjölund, 12 years ago

Not disable. Should not be visible until it is enabled. It takes up tons of space and people wonder how to enable it...

comment:3 by Adeel Asghar, 12 years ago

Resolution: fixed
Status: newclosed

OK. This makes sense :).
DONE.

comment:4 by Lennart Ochel, 12 years ago

I thought we wanted to reactivate „interactive simulation“ instead of hide the button. Willi said in the last OMDev meeting it is working as before …?!
Or is the integration not finished and interactive simulation is only working in command line mode? But there was already an (more or less) working interactive simulation integration in OMEdit, or not?

in reply to:  4 comment:5 by Adeel Asghar, 12 years ago

Replying to lochel:

I thought we wanted to reactivate „interactive simulation“ instead of hide the button. Willi said in the last OMDev meeting it is working as before …?!
Or is the integration not finished and interactive simulation is only working in command line mode? But there was already an (more or less) working interactive simulation integration in OMEdit, or not?

The last time I checked interactive simulation was not working even from command line. I sent an email to Willi about it but never heard anything back from him. However, even if it is working we still need time to add a support for it in OMEdit.

comment:6 by Lennart Ochel, 12 years ago

Okay. Thanks for that information.

comment:7 by Lennart Ochel, 12 years ago

Cc: Willi Braun added

comment:8 by Adrian Pop, 12 years ago

We even test the interactive simulation on both Linux and Windows as far as I know, so I don't know why the button is disabled. Have you tried recently Adeel?

comment:9 by Martin Sjölund, 12 years ago

No we don't. It was disabled because the tests never lined up properly. It needs 100% chance of success if we should have it.

comment:10 by Adrian Pop, 12 years ago

But we do test it in the Windows builds as far as I know.

comment:11 by Martin Sjölund, 12 years ago

Oh I tried to fix it, and then killed it in r15385 as it just would not work on all machines. The messages do not arrive in the same order every time.

comment:12 by Adrian Pop, 12 years ago

But that's fine as that's classic to threading.
Is hard to test, however, it does seem to work just fine.

in reply to:  8 comment:13 by Adeel Asghar, 12 years ago

Replying to adrpo:

We even test the interactive simulation on both Linux and Windows as far as I know, so I don't know why the button is disabled. Have you tried recently Adeel?

Just tried it with the trunk version and the result is same. It halts after 1 second. We should fix it first before supporting it in the GUI.

Note: See TracTickets for help on using tickets.