Opened 11 years ago

Closed 7 years ago

#2343 closed enhancement (worksforme)

Instantiatied extended models with records with constants have equations which could easily be simplified

Reported by: carlj@… Owned by: somebody
Priority: high Milestone: 2.0.0
Component: Frontend Version: trunk
Keywords: Cc:

Description

Consider the following model:

record MyRecord
  Real x;
  constant Real y = 0.5;
end MyRecord;

model BaseModel
  parameter MyRecord myData;
end BaseModel;

model ExtendsModel
  parameter MyRecord m(x = 1.27);
  extends BaseModel(myData = m);
end ExtendsModel;

which is instantiated to:

function MyRecord \"Automatically generated record constructor for MyRecord\"
  input Real x;
  protected Real y = 0.5;
  output MyRecord res;
end MyRecord;

class ExtendsModel
  parameter Real myData.x = m.x;
  constant Real myData.y = m.y;
  parameter Real m.x = 1.27;
  constant Real m.y = 0.5;
end ExtendsModel;

where the line "constant Real myData.y = m.y" seems like it could just as well be simplified to "constant Real myData.y = 0.5".

Change History (10)

comment:1 by Martin Sjölund, 11 years ago

Milestone: 1.9.01.9.1

Postponed until 1.9.1

comment:2 by Martin Sjölund, 10 years ago

Milestone: 1.9.11.9.2

This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).

comment:3 by Martin Sjölund, 10 years ago

Milestone: 1.9.21.9.3

Milestone changed to 1.9.3 since 1.9.2 was released.

comment:4 by Martin Sjölund, 9 years ago

Milestone: 1.9.31.9.4

Moved to new milestone 1.9.4

comment:5 by Martin Sjölund, 9 years ago

Milestone: 1.9.41.9.5

Milestone pushed to 1.9.5

comment:6 by Martin Sjölund, 9 years ago

Milestone: 1.9.51.10.0

Milestone renamed

comment:7 by Martin Sjölund, 8 years ago

Milestone: 1.10.01.11.0

Ticket retargeted after milestone closed

comment:8 by Martin Sjölund, 8 years ago

Milestone: 1.11.01.12.0

Milestone moved to 1.12.0 due to 1.11.0 already being released.

comment:9 by Francesco Casella, 7 years ago

Milestone: 1.12.0Future

The milestone of this ticket has been reassigned to "Future".

If you think the issue is still valid and relevant for you, please select milestone 1.13.0 for back-end, code generation and run-time issues, or 2.0.0 for front-end issues.

If you are aware that the problem is no longer present, please select the milestone corresponding to the version of OMC you used to check that, and set the status to "worksforme".

In both cases, a short informative comment would be welcome.

comment:10 by Francesco Casella, 7 years ago

Milestone: Future2.0.0
Resolution: worksforme
Status: newclosed

As of v1.13.0-dev-226-ga72f165, the new front end (-d=newInst) flattens P.ExtendsModels as

class P.ExtendsModel
  parameter Real m.x = 1.27;
  constant Real m.y = 0.5;
  parameter Real myData.x;
  constant Real myData.y = 0.5;
end P.ExtendsModel;

This will be the default behaviour in v. 2.0.0

Note: See TracTickets for help on using tickets.