#2344 closed defect (fixed)
Erroneous display of two MSL 3.2.1. components
Reported by: | massimo ceraolo | Owned by: | Adeel Asghar |
---|---|---|---|
Priority: | normal | Milestone: | 1.9.1 |
Component: | OMEdit | Version: | trunk |
Keywords: | Cc: |
Description
Using Omedit (R16954) the following MSL models do not display correctly:
1) Electrical.Analog.Examples.SimpleTriacCircuit
2) Electrical.Analog.Examples.IdealTriacCircuit
Attachments (6)
Change History (15)
comment:1 by , 11 years ago
Milestone: | 1.9.0 → 1.9.1 |
---|
comment:2 by , 11 years ago
I've found other cases of graphical misbehaviour of OMEdit.
Naturally the most important ones are those related to MSL, and to the System libraries.
In the System Dynamics library (enclosed with OM), there are several cases of graphical mistakes. One example is:
SystemDynamics.WorldDynamics.World3.Pollution_Dynamics
If one opens it, he sees several missing blocks.
comment:3 by , 11 years ago
Priority: | low → normal |
---|
by , 11 years ago
Attachment: | SimpleTriacCircuit-OMEdit.png added |
---|
by , 11 years ago
Attachment: | SimpleTriacCircuit-Dymola.png added |
---|
by , 11 years ago
Attachment: | IdealTriacCircuit-OMEdit.png added |
---|
by , 11 years ago
Attachment: | IdealTriacCircuit-Dymola.png added |
---|
comment:4 by , 11 years ago
What do you mean by Erroneous display?
The bug is probably already fix and you are using an old version. I am using the r19140.
Haven't tested the Pollution_Dynamics model because I need to build the libraries for it.
comment:5 by , 11 years ago
I did my checks with r19013.
I repeated today with r 19348 and I got the following results:
1) simpleTriacCircuit -> now is ok
2) IdealTriacCircuit -> now is ok
3) Pollution Dynamics -> still has problems
Screenshots:
- Pollution.tif. You can see that there are several lines that instead of connecting icons, seem to reach nothing.
- PollDym.tif screenshot of the same model with Dymola, that shows correct display of blocks and connecting lines.
by , 11 years ago
Attachment: | Pollution.tif added |
---|
by , 11 years ago
Attachment: | PollDym.tif added |
---|
comment:6 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
The problem was not in OMEdit. It was some old annotations in the library which OpenModelica compiler can't parse. I fixed them in the library https://github.com/adeas31/SystemDynamics/commit/23ce42787673138c91bdbed0726127042d36e83f
You need to update your OpenModelica so that you get a new library code or update library directly using the above link.
comment:7 by , 11 years ago
I've upgraded today to r19460.
The problem is still there.
I've uninstalled OM, cleared the directory, and installed it again.
The problem is still there.
Non only Pollution Dynamics, but also several other models within world3 of System Dynamics have got visualization problems.
Since the capability of simulating world3 of OM is a feat, that has also announced by Peter Fritson in the 2014-1 Modelica newsletter, in my opinion it is a good idea to spend some more time to fix it.
comment:8 by , 11 years ago
My mistake. I forgot to merge the changes with the library source. It is merged now https://github.com/modelica-3rdparty/SystemDynamics/commit/c58a26dc3e62a50e64fd336dc4aa499b2d5ad314
I just tested the nightly build r19492. Everything seems to work fine. If you find another bug please report it.
comment:9 by , 11 years ago
I've checked with r19498. The diagrams are ok know.
Just for completeness, I mention that in model
SystemDynamics.worldDynamics.World3.Hyman_Welfare_index
the connecting line from
HWI_Human_Welfare_index
to the model's output is incomplete.
BTW it is nearly impossible to see the name of the output interface from the diagram view: it is very tiny. But if one zooms in, this icon goes outside the screen ad cannot be moved inside using the horizontal scrollbar.
MC
Postponed until 1.9.1