Opened 11 years ago

Closed 7 years ago

#2357 closed discussion (wontfix)

runScript should change directory

Reported by: Christian Schubert Owned by: Martin Sjölund
Priority: high Milestone: 1.13.0
Component: Parser Version: trunk
Keywords: Cc: Martin Sjölund, Adrian Pop

Description

Hi everyone,

I like the new layout of the testsuite very much with the scripts in the common folder.

Something is a little bit awkward though. Every test calls the ModelTestingDefaults.mos via a runScript() command. It seems that this command does not cd() into the script directory as the mos script has to do

loadFile("../common/ModelTesting.mo");

to load a modelica file which is located in the same directory.

This is especially bad, if I want to include a file from some folder which is not exactly one level above common.

So my question is: Is it a bug or a feature? Are there any usecases where this behaviour is advantageous?

Regards,

Christian

Change History (14)

comment:1 by Martin Sjölund, 11 years ago

It's a feature. I use it a lot. You could perhaps make it work with an optional flag, but keep in mind it is bad to change working directory for partest.pl...

comment:2 by Christian Schubert, 11 years ago

Could you explain it a little bit more for me?

What do you use it for?
Why is it bad to change directories for partest.pl?

Should it be an option for the runScript() command or an option inside the ModelTesting.mo?

comment:3 by Martin Sjölund, 11 years ago

Flag for runScript in that case. Anyway, I use it a lot to generate files in the working directory.
I often have the scripts in read-only directories (such as the ones shipped with OpenModelica).

comment:4 by Christian Schubert, 11 years ago

I see. That does make sense.

comment:5 by Martin Sjölund, 11 years ago

Milestone: 1.9.01.9.1

Postponed until 1.9.1

comment:6 by Martin Sjölund, 10 years ago

Milestone: 1.9.11.9.2

This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).

comment:7 by Martin Sjölund, 10 years ago

Milestone: 1.9.21.9.3

Milestone changed to 1.9.3 since 1.9.2 was released.

comment:8 by Martin Sjölund, 9 years ago

Milestone: 1.9.31.9.4

Moved to new milestone 1.9.4

comment:9 by Martin Sjölund, 9 years ago

Milestone: 1.9.41.9.5

Milestone pushed to 1.9.5

comment:10 by Martin Sjölund, 9 years ago

Milestone: 1.9.51.10.0

Milestone renamed

comment:11 by Martin Sjölund, 8 years ago

Milestone: 1.10.01.11.0

Ticket retargeted after milestone closed

comment:12 by Martin Sjölund, 8 years ago

Milestone: 1.11.01.12.0

Milestone moved to 1.12.0 due to 1.11.0 already being released.

comment:13 by Francesco Casella, 7 years ago

Milestone: 1.12.0Future

The milestone of this ticket has been reassigned to "Future".

If you think the issue is still valid and relevant for you, please select milestone 1.13.0 for back-end, code generation and run-time issues, or 2.0.0 for front-end issues.

If you are aware that the problem is no longer present, please select the milestone corresponding to the version of OMC you used to check that, and set the status to "worksforme".

In both cases, a short informative comment would be welcome.

in reply to:  4 comment:14 by Francesco Casella, 7 years ago

Milestone: Future1.13.0
Resolution: wontfix
Status: newclosed

Replying to cschubert:

I see. That does make sense.

Note: See TracTickets for help on using tickets.