Opened 11 years ago
Last modified 7 years ago
#2378 new defect
addComponent does not handle the double declaration check
| Reported by: | Adeel Asghar | Owned by: | somebody |
|---|---|---|---|
| Priority: | high | Milestone: | Future |
| Component: | Interactive Environment | Version: | trunk |
| Keywords: | Cc: | Adrian Pop |
Description
Run the attached script and notice the change in the model.
loadFile checks the double declaration, the same check should be added for addComponent and renameComponentInClass.
Attachments (2)
Change History (15)
by , 11 years ago
| Attachment: | redefineComponent.mo added |
|---|
by , 11 years ago
| Attachment: | redefineComponent.mos added |
|---|
comment:1 by , 11 years ago
comment:2 by , 11 years ago
Just need to add:
_ := SCodeUtil.translateAbsyn2SCode(outProgram);
Or even better, do the SCode translation and store it in the symbol table so it is cached.
comment:3 by , 11 years ago
Translation might take too long for large buffers but
truth is it might be better to have correct programs.
comment:4 by , 11 years ago
Alternative is more specialized checks that only look new errors (or only translates the updated class).
comment:6 by , 10 years ago
| Milestone: | 1.9.1 → 1.9.2 |
|---|
This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).
comment:7 by , 10 years ago
| Milestone: | 1.9.2 → 1.9.3 |
|---|
Milestone changed to 1.9.3 since 1.9.2 was released.
comment:12 by , 8 years ago
| Milestone: | 1.11.0 → 1.12.0 |
|---|
Milestone moved to 1.12.0 due to 1.11.0 already being released.
comment:13 by , 7 years ago
| Milestone: | 1.12.0 → Future |
|---|
The milestone of this ticket has been reassigned to "Future".
If you think the issue is still valid and relevant for you, please select milestone 1.13.0 for back-end, code generation and run-time issues, or 2.0.0 for front-end issues.
If you are aware that the problem is no longer present, please select the milestone corresponding to the version of OMC you used to check that, and set the status to "worksforme".
In both cases, a short informative comment would be welcome.
Same should be for addClass/renameClass.