Opened 11 years ago

Last modified 7 years ago

#2378 new defect

addComponent does not handle the double declaration check

Reported by: adeas31 Owned by: somebody
Priority: high Milestone: Future
Component: Interactive Environment Version: trunk
Keywords: Cc: adrpo

Description

Run the attached script and notice the change in the model.
loadFile checks the double declaration, the same check should be added for addComponent and renameComponentInClass.

Attachments (2)

redefineComponent.mo​ (26 bytes) - added by adeas31 11 years ago.
redefineComponent.mos​ (152 bytes) - added by adeas31 11 years ago.

Download all attachments as: .zip

Change History (15)

Changed 11 years ago by adeas31

Changed 11 years ago by adeas31

comment:1 Changed 11 years ago by adrpo

Same should be for addClass/renameClass.

comment:2 Changed 11 years ago by sjoelund.se

Just need to add:

_ := SCodeUtil.translateAbsyn2SCode(outProgram);

Or even better, do the SCode translation and store it in the symbol table so it is cached.

comment:3 Changed 11 years ago by adrpo

Translation might take too long for large buffers but
truth is it might be better to have correct programs.

comment:4 Changed 11 years ago by sjoelund.se

Alternative is more specialized checks that only look new errors (or only translates the updated class).

comment:5 Changed 11 years ago by sjoelund.se

  • Milestone changed from 1.9.0 to 1.9.1

Postponed until 1.9.1

comment:6 Changed 10 years ago by sjoelund.se

  • Milestone changed from 1.9.1 to 1.9.2

This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).

comment:7 Changed 10 years ago by sjoelund.se

  • Milestone changed from 1.9.2 to 1.9.3

Milestone changed to 1.9.3 since 1.9.2 was released.

comment:8 Changed 9 years ago by sjoelund.se

  • Milestone changed from 1.9.3 to 1.9.4

Moved to new milestone 1.9.4

comment:9 Changed 9 years ago by sjoelund.se

  • Milestone changed from 1.9.4 to 1.9.5

Milestone pushed to 1.9.5

comment:10 Changed 9 years ago by sjoelund.se

  • Milestone changed from 1.9.5 to 1.10.0

Milestone renamed

comment:11 Changed 8 years ago by sjoelund.se

  • Milestone changed from 1.10.0 to 1.11.0

Ticket retargeted after milestone closed

comment:12 Changed 8 years ago by sjoelund.se

  • Milestone changed from 1.11.0 to 1.12.0

Milestone moved to 1.12.0 due to 1.11.0 already being released.

comment:13 Changed 7 years ago by casella

  • Milestone changed from 1.12.0 to Future

The milestone of this ticket has been reassigned to "Future".

If you think the issue is still valid and relevant for you, please select milestone 1.13.0 for back-end, code generation and run-time issues, or 2.0.0 for front-end issues.

If you are aware that the problem is no longer present, please select the milestone corresponding to the version of OMC you used to check that, and set the status to "worksforme".

In both cases, a short informative comment would be welcome.

Note: See TracTickets for help on using tickets.