Opened 10 years ago

Closed 3 years ago

Last modified 3 years ago

#2485 closed defect (fixed)

Redeclaration interpreted wrong with array dimensions

Reported by: choeger Owned by: adrpo
Priority: high Milestone: 1.16.0
Component: Frontend Version: trunk
Keywords: Cc:

Description

The following testcase is legal (according to section 7.3 of the Modelica spec p.73, last line):

model Test2
  model SomeComponent
    parameter Real x;
  end SomeComponent;
  
  model SomeOtherComponent
    parameter Real x;
  end SomeOtherComponent;
  
  model User1
    replaceable SomeComponent[3] c(x = {1,2,3});
  end User1;
  
  model User2
    User1 u(redeclare SomeOtherComponent c);
  end User2;
  
  
  User2 u;
  
  parameter Real x = u.u.c[3].x;
  
end Test2;

omc rejects it because it treats the redeclaration literally.

As a side-note: omc's interpretation of the redeclaration is an incompatible modification anyway (since X is never a subtype of X[:]).

Change History (12)

comment:1 Changed 10 years ago by perost

  • Component changed from Backend to Frontend
  • Owner changed from probably noone to somebody

comment:2 Changed 10 years ago by adrpo

  • Owner changed from somebody to adrpo
  • Status changed from new to accepted

Yeah, we probably do not use the dimensions from the original component. Should be an easy fix.

comment:3 Changed 9 years ago by sjoelund.se

  • Milestone changed from 1.9.1 to 1.9.2

This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).

comment:4 Changed 9 years ago by sjoelund.se

  • Milestone changed from 1.9.2 to 1.9.3

Milestone changed to 1.9.3 since 1.9.2 was released.

comment:5 Changed 9 years ago by sjoelund.se

  • Milestone changed from 1.9.3 to 1.9.4

Moved to new milestone 1.9.4

comment:6 Changed 8 years ago by sjoelund.se

  • Milestone changed from 1.9.4 to 1.9.5

Milestone pushed to 1.9.5

comment:7 Changed 8 years ago by sjoelund.se

  • Milestone changed from 1.9.5 to 1.10.0

Milestone renamed

comment:8 Changed 7 years ago by sjoelund.se

  • Milestone changed from 1.10.0 to 1.11.0

Ticket retargeted after milestone closed

comment:9 Changed 7 years ago by sjoelund.se

  • Milestone changed from 1.11.0 to 1.12.0

Milestone moved to 1.12.0 due to 1.11.0 already being released.

comment:10 Changed 6 years ago by casella

  • Milestone changed from 1.12.0 to Future

The milestone of this ticket has been reassigned to "Future".

If you think the issue is still valid and relevant for you, please select milestone 1.13.0 for back-end, code generation and run-time issues, or 2.0.0 for front-end issues.

If you are aware that the problem is no longer present, please select the milestone corresponding to the version of OMC you used to check that, and set the status to "worksforme".

In both cases, a short informative comment would be welcome.

comment:11 Changed 3 years ago by perost

  • Resolution set to fixed
  • Status changed from accepted to closed

Works fine in both the old and the new frontend.

comment:12 Changed 3 years ago by casella

  • Milestone changed from Future to 1.16.0
Note: See TracTickets for help on using tickets.