Opened 11 years ago
Closed 7 years ago
#2613 closed defect (fixed)
combined modification and redeclaration
Reported by: | DanielH | Owned by: | Per Östlund |
---|---|---|---|
Priority: | high | Milestone: | 1.13.0 |
Component: | New Instantiation | Version: | trunk |
Keywords: | redeclaration, modification | Cc: |
Description
I reported this on the forum
https://openmodelica.org/index.php/forum/topic?id=1152
but I didn't get an answer so I report it here because I think it's important.
consider the following:
model M1 parameter Real a = 1; parameter Real b = 1; end M1; model M0 parameter Real a = 0; parameter Real b = 0; end M0; model N replaceable M0 m; end N; model B N n(m.a = 3, redeclare M1 m, m.b = 3); end B;
when I simulate model B, I get
n.m.a = 3
n.m.b = 1
I think it's wrong because the order of modification (inside one declaration) should not matter.
Change History (9)
comment:1 by , 10 years ago
Milestone: | 1.9.1 → 1.9.2 |
---|
comment:2 by , 10 years ago
Milestone: | 1.9.2 → 1.9.3 |
---|
Milestone changed to 1.9.3 since 1.9.2 was released.
comment:7 by , 8 years ago
Milestone: | 1.11.0 → 1.12.0 |
---|
Milestone moved to 1.12.0 due to 1.11.0 already being released.
comment:8 by , 7 years ago
Milestone: | 1.12.0 → Future |
---|
The milestone of this ticket has been reassigned to "Future".
If you think the issue is still valid and relevant for you, please select milestone 1.13.0 for back-end, code generation and run-time issues, or 2.0.0 for front-end issues.
If you are aware that the problem is no longer present, please select the milestone corresponding to the version of OMC you used to check that, and set the status to "worksforme".
In both cases, a short informative comment would be welcome.
comment:9 by , 7 years ago
Milestone: | Future → 1.13.0 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Both the old and new front end now report
[2] 19:28:45 Translation Error [Test: 17:7-17:14]: Duplicate modification of element m on component n.
which I guess is correct in this case.
This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).