NFScodeDependency stack overflow

[sjoelund.se]

FCSys.Assemblies.Cells.Cell gives a stack overflow in the dependency analysis (so I cannot upload the total model). ​https://github.com/kdavies4/FCSys/archive/master.zip

loadModel(FCSys);getErrorString();
saveTotalModel("total.mo",FCSys.Assemblies.Cells.Cell);getErrorString();

[sjoelund.se]

Fixed in r22716 (the library has plenty of other issues though)

[perost]

Not really fixed though, the fix has issues...

[sjoelund.se]

Stupid Hudson and new broken tests :) The fix solves this issue though... Fine, let's leave this open for a while.

[perost]

Yes, I reverted the stack overflow fix, it really wasn't a good fix. I don't quite know how to fix this right now, but as you say the library has lots of other issues anyway.

[sjoelund.se]

This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).

[sjoelund.se]

Note that ​https://test.openmodelica.org/hudson/view/Coverage/job/FCSys_Coverage/ and ​https://test.openmodelica.org/hudson/view/Coverage/job/HelmholtzMedia_Coverage/ both generate very large traces now. It would be good to fix this in some way.

[sjoelund.se]

See also #3037

[sjoelund.se]

Milestone changed to 1.9.3 since 1.9.2 was released.

[sjoelund.se]

Moved to new milestone 1.9.4

[sjoelund.se]

Milestone pushed to 1.9.5

[sjoelund.se]

Milestone renamed

[Christoph <buchner@…>]

According to the ​docs, FCSys does not even support OM. In fact, I have never seen it pass a single test on Hudson. Maybe this should just be removed from the list of libraries, as it just takes up build time for no good reason?

[sjoelund.se]

Ticket retargeted after milestone closed

[sjoelund.se]

Milestone moved to 1.12.0 due to 1.11.0 already being released.

[casella]

The milestone of this ticket has been reassigned to "Future".

If you think the issue is still valid and relevant for you, please select milestone 1.13.0 for back-end, code generation and run-time issues, or 2.0.0 for front-end issues.

If you are aware that the problem is no longer present, please select the milestone corresponding to the version of OMC you used to check that, and set the status to "worksforme".

In both cases, a short informative comment would be welcome.