Memory leak in ModelicaSimulationError?

[Rüdiger Franke]

r25329 (re-)commits the code:

class ModelicaSimulationError : public std::runtime_error 
{ 
  public: 
    ModelicaSimulationError(SIMULATION_ERROR error_id, const std::string& error_info) 
    : runtime_error(strdup(error_info.c_str())) 
    , _error_id(error_id) 
    { 
    } 

Who frees the memory allocated with strdup?

[Adrian Pop]

I remember I added the strdup because sometimes crashed on throw.
You can try to remove it and see which models fail and why.

[Rüdiger Franke]

I think the overloaded what() method was the problem. It created the message in a local variable and returned a pointer to it. r25356 creates the message during construction instead, exploiting its storage in std::runtime_error.