Cannot override array variables

[crupp@…]

The command line option -override and -overrideFile do not allow overrides of array variables. This is because the override string is tokenized by ",", which also catches the array dimension separator. This happens at simulation_input_xml.cpp:838.

The same problem happens with the -output option in solver_main.c:773. Could this happen anywhere else?

A quick fix would be to use a different separator character that would never exist in a variable name such as ";" and thereby avoid this issue.

Here is an example that reproduces the problem:

model overrideBug
  parameter Real[2,2] A = {{1,2},{3,4}};
  Real[2] x(start={1,2});
  Real[2] y;
equation
  y = der(x);
  der(y) = A * x;
end overrideBug;

Output:

./overrideBug.exe -override A[1,1]=0
stdout            | warning | simulation_input_xml.cpp: override variable name not found in model: 1]
stdout            | warning | simulation_input_xml.cpp: override variable name not found in model: A[1

[Adrian Pop]

Ouch, I didn't think of that. We can either fix this as you suggest using ";" as separator or we make the parsing of variables a bit more clever.

[Martin Sjölund]

; is allowed in variable names :)

[Adrian Pop]

Yeah. We should change this to ignore "," inside [ ]:

char *p = strtok(overrideStr, ",");

I'll see what I can do.

[Adrian Pop]

Fixed in r25370.

[crupp@…]

What about command line outputs? Same problem, should be the same fix.

[Adrian Pop]

What do you mean? I don't get it.
The command line outputs should be parsed by the external program that reads them :)

[crupp@…]

The -output flag won't dump the value of an array variable. For example,

./overrideBug.exe -output x[1],A[1,1]
time=1,x[1]=4.846927041353899

does not dump out A[1,1] due to a similar tokenizing bug at solver_main.c:773.

[Adrian Pop]

Ok. Now I get it. I'll have a look.

[Adrian Pop]

Properly fixed in r25376.