Logging changed to the worse

[Rüdiger Franke]

Yesterday the commit "* Typos, Indention, Logging" suggested some polishing. But at least one thing has changed to the worse.

Yesterday I got for quite some models, e.g. Modelica.Fluid.Examples.InverseParameterization, the message:

simulation error message : Variable orifice.dp_small out of [min, max] interval: orifice.dp_small >= 611.657 and orifice.dp_small <= 100000000.0 has value: 1

This message helped was helpful. Today I get

simulation error message : Could initialize system.

This is not only the opposite of what happened, it is also completely unspecific!

[Rüdiger Franke]

@lochel: you might also adapt the list of Components that can be selected for a ticket. For instance rename "FMI-CPP" to "Cpp Run-time"

[Adrian Pop]

I changed the FMI-CPP to CPP Run-time.

[Martin Flehmig]

Fixed in commit 1213c368d1d49edeb4e7b5a24dcbfcd43d1b03b9/OMCompiler

[Rüdiger Franke]

There is a misspelled newline. See e.g.:

​https://test.openmodelica.org/libraries/MSL_3.2.1_cpp/files/Modelica.Fluid.Examples.TraceSubstances.RoomCO2WithControls.sim

Don't get me wrong -- but this log shows up in many test reports once the testsuite will be updated -- and all these tests will formally fail if the log output changes.

[Marcus Walther]

Hi Rüdiger,
Martin has just changed the output if an exception occurs. Of course the "\n" issue must be fixed. But if I understand you correctly, you said that we have models with an error-message in their expected output? That should not be the case in my opinion. If an error occurs, the test should fail (except it is a test case that should test the error handling, but I think we do not have such a case).

[Rüdiger Franke]

I'm referring to the testsuite/simulation/libraries/msl32_cpp, where all models are tested. You might be right if a model that enconters a simulation error would at most be tested for compilation. Don't we have logs for error recoveries during simulation?

[Martin Flehmig]

Thanks for the hin regarding the misspelled newline. This is fixed in commit 385a51dff3374efbcccaa4ffe07ee28b68bd3c90.

[Marcus Walther]

@rfranke: Can we now set the ticket to "fixed"?