Opened 10 years ago

Closed 6 years ago

#3567 closed defect (fixed)

diffModelicaFileListings removes within clause

Reported by: Adeel Asghar Owned by: Martin Sjölund
Priority: blocker Milestone: 1.14.0
Component: Interactive Environment Version:
Keywords: Cc:

Description

Use the attached script to produce the error. diffModelicaFileListings removes the within clause from the model and also adds extra parentheses around the variable in the equation section.

Attachments (1)

script.mos​ (1.0 KB ) - added by Adeel Asghar 10 years ago.

Download all attachments as: .zip

Change History (11)

by Adeel Asghar, 10 years ago

Attachment: script.mos​ added

comment:1 by Martin Sjölund, 10 years ago

As for the within ;; is it expected that we always add it or that we only add it if it was there to begin with?

comment:2 by Adeel Asghar, 10 years ago

I think only preserve it if it is there.

comment:3 by Martin Sjölund, 10 years ago

Milestone: 1.9.4 → 1.9.5

Milestone pushed to 1.9.5

comment:4 by Martin Sjölund, 10 years ago

Milestone: 1.9.5 → 1.10.0

Milestone renamed

comment:5 by Martin Sjölund, 9 years ago

Milestone: 1.10.0 → 1.11.0

Ticket retargeted after milestone closed

comment:6 by Martin Sjölund, 9 years ago

Milestone: 1.11.0 → 1.12.0

Milestone moved to 1.12.0 due to 1.11.0 already being released.

comment:7 by Francesco Casella, 8 years ago

Milestone: 1.12.0 → Future

The milestone of this ticket has been reassigned to "Future".

If you think the issue is still valid and relevant for you, please select milestone 1.13.0 for back-end, code generation and run-time issues, or 2.0.0 for front-end issues.

If you are aware that the problem is no longer present, please select the milestone corresponding to the version of OMC you used to check that, and set the status to "worksforme".

In both cases, a short informative comment would be welcome.

comment:8 by Francesco Casella, 6 years ago

Milestone: Future → 1.14.0
Priority: high → blocker

This issue is still valid, I think we should get rid of all these diffModelicaListings bugs for 1.14.0, if possible.

comment:9 by Francesco Casella, 6 years ago

Milestone: 1.14.0 → 1.15.0

Releasing 1.14.0 which is stable and has many improvements w.r.t. 1.13.2.

This issue, previously marked as blocker for 1.14.0, is rescheduled to 1.15.0

comment:10 by Adeel Asghar, 6 years ago

Milestone: 1.15.0 → 1.14.0
Resolution: → fixed
Status: new → closed

This was fixed already fixed for 1.14. The within is now preserved if present in the class.

Note: See TracTickets for help on using tickets.