Sometimes OMEdit does not delete connect equations

[anonymous]

In OMEdit, when you delete a model, also the related connecting lines must be deleted.
Deleting the connecting lines must be associated to the deletion of the corresponding connect equations.

In OMEdit, however, frequently happens that when one deletes a model (in diagram view) even though connecting lines are deleted, not all the related connect equations are deleted. When checking the resulting model, therefore, errors occur.

Unfortunately this behaviour is rather erratic, and, although it happens rather frequently, I never succeeded to create a repetitive procedure to reproduce it.
I've seen this behaviour at least during a the whole last year.

Finally I decided to open this ticket, just in case the developers, looking at the code, are able to find something strange about deleting connect equations as a consequence of the user's deletion (in diagram view) of a model.

[Adeel Asghar]

Never faced this issue before. Would be nice if you could provide a test-case.

[anonymous]

Finally I succeeded in finding a sequence showing the issue!

1) load and open "RenaTest.mo" in diagram view
2) rename "constantVoltage1" into "fem". Now check model ->ok
3) add another resistor in the circuit (for instance you can obtain the circuit shown in the enclosed png)
4) check the model again -> error! OMEdit complains something about"constantVoltage1"

that indeed is not part of the circuit anymore. In the text view an extra connect equation regarding constantVoltage1 appears.

[Adeel Asghar]

I can't reproduce it :). I followed all your steps. For step 3 I added a new resistor and then deleted the existing connection between resistor1 and resistor2, and then made a connection between resistor1 and resistor3 and a connection between resistor3 and resistor2.

[Adeel Asghar]

Post your omeditcommunication.log file. You can find it in %TEMP%/OpenModelica/OMEdit.

[anonymous]

here you are

[Adeel Asghar]

Fixed in 538f96a/OMEdit.

The problem was that, after renaming constantVoltage1 if user moves resistor1 then updateConnection is called which was using the old names. So the fix was to update the names to new when user do the renaming.

[anonymous]

A simpler procedure to showing the issue
1) load and open "RenaTest.mo" in diagram view
2) rename "constantVoltage1" into "fem". Now check model ->ok
3) move resistor2 (e.g. with a single using right-arrow click on the keyboard). Now check model. Error

Error message:
[1] 08:27:28 Translation Error
Variable constantVoltage1.n not found in scope RenaTest.

[2] 08:27:28 Translation Error
Error occurred while flattening model RenaTest

[anonymous]

Sorry for the message of a minute a go.
I did not see that you already fixed it!

[anonymous]

The issue is still present.
Steps:
1) load RenaTest.mo; check->ok
2) delete resistor1
3) connect constantVoltage1.p with resistor2.p check->ok
4) move resistor2 check-> error!

[Adeel Asghar]

Fixed in af41062/OMEdit.
Btw, thanks for testing and reporting such issues!

[Martin Sjölund]

Milestone renamed

[Martin Sjölund]

Milestone renamed