OMEdit does not render some icons

[Rüdiger Franke]

OMEdit does not render all icons. Has this to do with recent optimizations?

Load e.g. Modelica_Synchronous (see github.com/Modelica)
Then open Modelica_Synchronous.Examples.RealSignals.Sample1

The icon of assignClock is not shown (see attached screenshot).

[Martin Sjölund]

If this is due to a missing class, I guess OMEdit could display a tooltip saying why the class is marked in red :)

[Adrian Pop]

I think this might be some bug with the fact that Clock is a connector.

[Adeel Asghar]

One reason is,

getIconAnnotation(Modelica_Synchronous.RealSignals.Sampler.AssignClock)
{annotation(Icon(coordinateSystem(preserveAspectRatio = false, extent = {{-100, -100}, {100, 100}}, grid = {2, 2}, initialScale = 0.06), graphics = {Text(extent = {{-200, 100}, {200, 160}}, lineColor = {0, 0, 255}, textString = "%name"), Rectangle(extent = {{-90, 90}, {88, -88}}, fillColor = {255, 255, 255}, fillPattern = FillPattern.Solid, pattern = LinePattern.None), Line(points = {{-80, -60}, {-40, -60}, {-40, 0}, {0, 0}, {0, 0}, {0, 0}, {0, 80}, {40, 80}, {40, 40}, {80, 40}, {80, 0}, {80, 0}, {80, 0}, {100, 0}}, color = {0, 0, 127}, pattern = LinePattern.Dot), Line(points = {{-80, -60}, {-80, 0}, {-106, 0}}, color = {0, 0, 127}, smooth = Smooth.None, pattern = LinePattern.Dot), Ellipse(extent = {{-90, -50}, {-70, -70}}, lineColor = {0, 0, 127}, fillColor = {255, 255, 255}, fillPattern = FillPattern.Solid), Ellipse(extent = {{-50, 10}, {-30, -10}}, lineColor = {0, 0, 127}, fillColor = {255, 255, 255}, fillPattern = FillPattern.Solid), Ellipse(extent = {{-10, 90}, {10, 70}}, lineColor = {0, 0, 127}, fillColor = {255, 255, 255}, fillPattern = FillPattern.Solid), Ellipse(extent = {{30, 50}, {50, 30}}, lineColor = {0, 0, 127}, fillColor = {255, 255, 255}, fillPattern = FillPattern.Solid), Ellipse(extent = {{70, 10}, {90, -10}}, lineColor = {0, 0, 127}, fillColor = {255, 255, 255}, fillPattern = FillPattern.Solid), Line(visible = useClock, points = {{0, -100}, {0, 0}}, color = {175, 175, 175}, pattern = LinePattern.Dot, smooth = Smooth.None, thickness = 0.5)})) }

But this not a main issue, The main reason is,

getInheritedClasses(Modelica_Synchronous.ClockSignals.Interfaces.ClockInput)
{Clock}

Clock doesn't exist.

[Adeel Asghar]

The getIconAnnotation fails because we have visible=useClock in annotation,

Line(visible=useClock,
          points={{0,-100},{0,0}},
          color={175,175,175},
          pattern=LinePattern.Dot,
          smooth=Smooth.None,
          thickness=0.5)

[Adrian Pop]

This is a bug in the library as "useClock" does not really exist in the model: Modelica_Synchronous.RealSignals.Sampler.AssignClock.
Maybe if we don't find a variable in the model we should return "false".

[Adrian Pop]

I now created a ticket on Modelica Trac about this: #​m:1919.

[Adrian Pop]

The Modelica ticket has now been fixed but I don't know when the changes will propagate to our libraries (if so) as this is on the master branch:
​https://github.com/modelica/Modelica_Synchronous/commit/65ac4a5988beca1e554823f7970e3a247ed6f15e

[Martin Sjölund]

Milestone pushed to 1.9.5

[Martin Sjölund]

Milestone renamed

[Dietmar Winkler]

I think this is the same issue as #3657

[Adeel Asghar]

Replying to dietmarw:

I think this is the same issue as #3657

No it's not. See comment:7:ticket:3657.

[Martin Sjölund]

Ticket retargeted after milestone closed

[Martin Sjölund]

Milestone moved to 1.12.0 due to 1.11.0 already being released.

[Francesco Casella]

The milestone of this ticket has been reassigned to "Future".

If you think the issue is still valid and relevant for you, please select milestone 1.13.0 for back-end, code generation and run-time issues, or 2.0.0 for front-end issues.

If you are aware that the problem is no longer present, please select the milestone corresponding to the version of OMC you used to check that, and set the status to "worksforme".

In both cases, a short informative comment would be welcome.