Opened 9 years ago

Last modified 7 years ago

#3731 assigned defect

OMEdit creates unnecessary empty Icon and Diagram annotation

Reported by: dietmarw Owned by: adrpo
Priority: high Milestone: Future
Component: Interactive Environment Version: v1.9.4-dev-nightly
Keywords: Cc:

Description (last modified by dietmarw)

When creating a new class with OMEdit will always add the line

annotation(Icon, Diagram);

even to classes where this doesn't make sense. It's simply just adds noise to the code which is especially annoying when having your code under version control.

Change History (9)

comment:1 Changed 9 years ago by dietmarw

  • Description modified (diff)

comment:2 Changed 9 years ago by adeas31

  • Component changed from OMEdit to Interactive Environment
  • Owner changed from adeas31 to adrpo
  • Status changed from new to assigned

Done in 77fc815/OMEdit.

You will not get empty annotations now when you create a class. But you will get them when for example you update the coordinate system and then undo it. The reason is, OMEdit skips the default values which leads to the creation of empty annotations. We need to fix addClassAnnotation API so when the annotation is empty it should not add it to the class.

comment:3 Changed 9 years ago by dietmarw

  • Summary changed from OMEdit creates unnecessary empy Icon and Diagram annotation to OMEdit creates unnecessary empty Icon and Diagram annotation

comment:4 Changed 9 years ago by dietmarw

OK, thanks. Also I like to mention that having added annotation(Icon, Diagram); is at least better than what Dymola does with adding the default coordinate system everywhere.

comment:5 Changed 9 years ago by sjoelund.se

  • Milestone changed from 1.9.4 to 1.9.5

Milestone pushed to 1.9.5

comment:6 Changed 9 years ago by sjoelund.se

  • Milestone changed from 1.9.5 to 1.10.0

Milestone renamed

comment:7 Changed 8 years ago by sjoelund.se

  • Milestone changed from 1.10.0 to 1.11.0

Ticket retargeted after milestone closed

comment:8 Changed 8 years ago by sjoelund.se

  • Milestone changed from 1.11.0 to 1.12.0

Milestone moved to 1.12.0 due to 1.11.0 already being released.

comment:9 Changed 7 years ago by casella

  • Milestone changed from 1.12.0 to Future

The milestone of this ticket has been reassigned to "Future".

If you think the issue is still valid and relevant for you, please select milestone 1.13.0 for back-end, code generation and run-time issues, or 2.0.0 for front-end issues.

If you are aware that the problem is no longer present, please select the milestone corresponding to the version of OMC you used to check that, and set the status to "worksforme".

In both cases, a short informative comment would be welcome.

Note: See TracTickets for help on using tickets.