Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#3787 closed enhancement (fixed)

Display OMEdits own version string in "About OMEdit"

Reported by: Dietmar Winkler Owned by: Adeel Asghar
Priority: normal Milestone:
Component: OMEdit Version: v1.10.0-dev-nightly
Keywords: Cc:

Description

Especially for testing the nightly version it would help if the "About OMEdit" dialogue would display also OMEdit's git describe string and not just the one of OpenModelica it is connected to.

It could look like

OpenModelica Connection Editor
(v1.10.0-dev-24-g91ea31c)

Connected to OpenModelica 1.10.0~dev-85-g6aa2d74

Attachments (2)

AboutOMEdit.png (124.8 KB ) - added by Adeel Asghar 9 years ago.
AboutOMEditLinux.png (171.0 KB ) - added by Dietmar Winkler 9 years ago.

Download all attachments as: .zip

Change History (16)

by Adeel Asghar, 9 years ago

Attachment: AboutOMEdit.png added

comment:1 by Adeel Asghar, 9 years ago

Resolution: invalid
Status: newclosed

Its already done several weeks ago.
See the attached screenshot.

comment:2 by Dietmar Winkler, 9 years ago

Resolution: invalid
Status: closedreopened

Not on Linux unfortunately:


Last edited 9 years ago by Dietmar Winkler (previous) (diff)

by Dietmar Winkler, 9 years ago

Attachment: AboutOMEditLinux.png added

comment:3 by Adeel Asghar, 9 years ago

Owner: changed from Adeel Asghar to Martin Sjölund
Status: reopenedassigned

comment:4 by Martin Sjölund, 9 years ago

Owner: changed from Martin Sjölund to Adeel Asghar

comment:5 by Adeel Asghar, 9 years ago

Should work fine in 58e0b64/OMEdit.
I don't have Linux version of OMEdit so I let you to test it.

comment:6 by Dietmar Winkler, 9 years ago

OK so I've tested this now over the last couple of days. It seems that now the "About OMEdit" window simply displays the same git describre for OMC twice. But the whole purpose was that you got a different git hash of your OMEdit than of your omc. It could of course been that accidentally the latest change in the nightly was indeed done in the OMEdit repo and hence the OpenModelica hash is the same as the OMEdit one. But could you check this please?

comment:7 by anonymous, 9 years ago

From the screen shot it can be seen that the paragraph "Initially developed by ..." is not completely visible.

in reply to:  7 comment:8 by Adeel Asghar, 9 years ago

Replying to anonymous:

From the screen shot it can be seen that the paragraph "Initially developed by ..." is not completely visible.

This is already fixed in 58e0b64/OMEdit.

comment:9 by Dietmar Winkler, 9 years ago

OK I can finally confirm this as fixed. Though I could not find the proper commit that fixed the Linux build again.

comment:10 by Martin Sjölund, 9 years ago

There is no commit in the source repos for that. It is done by generating a REVISION file when converting the git repository to a source tarball (same as for OpenModelica.git).

comment:11 by Dietmar Winkler, 9 years ago

And the script doing this job is not versioned?

comment:12 by Martin Sjölund, 9 years ago

It is, but the repo contains signing keys, etc. So it is not public.

comment:13 by Dietmar Winkler, 9 years ago

Resolution: fixed
Status: assignedclosed

I see.

comment:14 by Martin Sjölund, 7 years ago

Milestone: 1.10.0

Milestone deleted

Note: See TracTickets for help on using tickets.