3d support for simple "coffee cup" animation

[Dietmar Winkler]

In my class I use a small example of a coffee cup by Michael Tiller. The library which Michael Tiller build contains at first very simple models which get extended and in the end there is a CupOfCoffeeAnimation example that unfortunately is not visualised at all by the latest nightly of OMEdit.

It simulates fine just the 3d visualisation is missing.

Opening CupOfCoffeeAnimation reports the following Errors:

[2] 14:25:46 Translation Error
[Modelica.Mechanics.MultiBody.Visualizers: 1979:8-1980:83]: PartialModelicaServices is partial, name lookup is not allowed in partial classes.

[3] 14:25:46 Translation Error
[ModelicaServices: 583:5-584:81]: PartialModelicaServices is partial, name lookup is not allowed in partial classes.

[Dietmar Winkler]

BasicModelica library by Michael Tiller

[Volker Waurich]

I dont get this error but I found an issue anyway. The modelname contains Ani"mat"ion which interferes with the filenameparsing of mat files ;)
Besides that, there is an issue with r_shape object. I will have a look.

[Adeel Asghar]

I already fixed the file name parsing issue see ccaec3f/OMEdit.

[Adeel Asghar]

I am also unable to reproduce the error. See the attached screenshot.

[Dietmar Winkler]

Mhh not really sure how I can help further. All I can say is that I get an empty animation window and the scripting error:

[2] 15:34:11 Scripting Error
Could not find the visual XML file BasicModelica.CupOfCoffeeAnion_visual.xml.

When "Simulation with Animation" is clicked. this is with OMEdit version 1.11.0~dev-231-g965594a On Ubuntu 16.04.1 64bit.

[Adeel Asghar]

This is fixed in ccaec3f/OMEdit.

[Adeel Asghar]

Besides that, there is an issue with r_shape object. I will have a look.

Sorry just closed the ticket in a haste. Reopening it now because of the above comment from Volker.

[Dietmar Winkler]

Ah right now I see. So the version I used DOES have the issue because of the MAT name. Renaming the model I get the same result like shown in the screen shot with the "floating" cup wall :-)

[Volker Waurich]

Ah.. Very good Adeel. Shall I fix the coffe cup?

[Adeel Asghar]

Yes, please!

[Volker Waurich]

I added​PR56.
There 2 variants of visualizing pipes in Modelica.Mechanics.MultiBody.Visualizers.Advanced.Shape . Either with "pipe" or "pipecylinder" as shape type. Can anyone tell me the difference?

[Dietmar Winkler]

Have a look at the info layer of Modelica.Mechanics.MultiBody.Types.ShapeType. There is an image that shows what pipe (hollow pipe) is and what cylinder (filled) is. There is actually no "pipecylinder". But neither is there in the cup of coffee model.

[Volker Waurich]

Check out the annotation of type Shape.Type:
"Type of shape (box, sphere, cylinder, pipecylinder, cone, pipe, beam, gearwheel, spring, <external shape>)"}

I have implemented it since I had models which used pipecylinder.

[Volker Waurich]

e.g. Modelica.Mechanics.MultiBody.Parts.BodyCylinder

[Dietmar Winkler]

Right. So what kind of shape is that. Also this does not explain why the cup wall is floating right?

[Volker Waurich]

I obviously haven't testet pipes before. There have been pipecylinders only in MSL. The fix is to handle pipes like pipecylinders.