OMEdit: display outline of models for system libraries in Diagram View

[janK]

If one opens a system library in OMEdit the outline (white box on gray background) and the grid is not displayed in the Diagram View as it is when working on own files. This is presumably done to show, that the models are read-only.

But actually, one get's the feeling that the models are incomplete and the connectors (in Diagram view) are flying around. Just because the visual feedback of the outline is missing.

So my suggestion is to actually show the models as a white box on gray background as this information is indeed given by e.g. (extent={{-100,-100},{100,100}}).

I think it is ok, to just hide the grid, to show that these libraries are "fixed" and read-only.

[janK]

Well, I admit that in Dymola, the model is also shown without the outline. But why can't be OMEdit be a better editor than Dymola? :-P

[adeas31]

I have changed it to draw the outline and grid (if enabled) for system libraries. 61d19ba/OMEdit.

It's not a good idea to hide the grid since grid is used as a Boolean switch for all models. So if its on then all models have the grid and if its off then all models don't have the grid. Also OMEdit remembers this decision for the next session.

If I programmatically switch it off then I have to add grid switch to each model OR I can use global one but have to remember its previous state.

[janK]

Isn't it possible to generally disable the grid for system libraries (despite their flag in that case)?
I mean remove && !pModelWidget->getLibraryTreeItem()->isSystemLibrary());
in line 5468?

I guess there should be a visual differentiation between user and system libraries.
IMHO, white outer background, a gray outline, white inner background and no grid would be perfect for system libraries.

[adeas31]

What I understand from your comment is,

• for system libraries Grid Lines tool button is disabled.
• Show white outer background, a gray outline, white inner background and no grid lines.

This is done in c3006bd/OMEdit.

[janK]

Oh, ok! I never noticed that grid button in the toolbar next to the zoom buttons - Sorry.
So then I actually meant to tick or untick that button.

[adeas31]

OK then I guess we are back on my comment:2.
I should not programmatically untick the button since this will untick it for all models. We have two options here one is to keep this button enabled and show the grid lines based on its on/off state for system libraries the other one is the current solution that disable the button and hide the grid lines for system libraries.

[janK]

The behavior in the latest nightly build (OpenModelica-v1.12.0-dev-395-gdeeabde-64bit.exe) is exactly how I imagined it. Disabling the grid button is the best solution. The ticket can be closed now.