Opened 8 years ago

Closed 8 years ago

#4421 closed defect (fixed)

Units of measure field loads a "save as.." dialog

Reported by: anonymous Owned by: Adeel Asghar
Priority: high Milestone: 1.12.0
Component: OMEdit Version:
Keywords: Cc:

Description

In the new 1.12.alpha1 OM version, units of measure in parameters dialog are somewhat crazy: in many cases they contain a button "..." which opens a "Save as" dialog, which seems crazy.

Nearly all MSL components have this strange behaviour. A rather rich example is
Modelica.Electrical.Machines.BasicMachines.AsynchronousInductionMachines.AIM_SquirrelCage (General tab)

Moreover: in many cases there is just one possible unit. In these cases, it would be much better to have a fixed value instead of a combo-box.

Attachments (2)

TrapezoidParameters.png (76.3 KB ) - added by Andrea Bartolini 8 years ago.
TrapezoidParameters-New.png (15.1 KB ) - added by Adeel Asghar 8 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 by Jan Kokert, 8 years ago

Seems to be related to #4353 (last point)

comment:2 by Adeel Asghar, 8 years ago

Resolution: fixed
Status: newclosed

The button ... is not unit. It is file selector button representing the loadSelector or saveSelector annotation. See #4303. You can read more about it in the Modelica specification. Used for example in Modelica.Blocks.Table.CombiTable1D.

There was a minor initialization problem because of which it is showing up for almost every parameter. I have fixed this now in 5215a82/OMEdit.

I have also changed it to show a fixed value in case when there is only one unit. 1830335/OMEdit.

comment:3 by Andrea Bartolini, 8 years ago

Resolution: fixed
Status: closedreopened

It seems the initialization problem is still present...

see attached file, which shows the parameter pop-up of MSL trapezoid.

OMEdit 1.12.0~dev-305-g4922085
Connected to OpenModelica 1.12.0~dev-782-gb6bd509
sysop Ubuntu 16.04

by Andrea Bartolini, 8 years ago

Attachment: TrapezoidParameters.png added

comment:4 by Adeel Asghar, 8 years ago

Andrea, I said the issue is fixed in 5215a82/OMEdit. The commit is made on 2017-06-01. You are using 4922085/OMEdit which is from 2017-05-24.

Please update your OpenModelica and test again.

by Adeel Asghar, 8 years ago

Attachment: TrapezoidParameters-New.png added

comment:5 by Andrea Bartolini, 8 years ago

Resolution: fixed
Status: reopenedclosed

Hi Adeel,
you are right... excuse me for the wrong comment.

I update every morning my nightly built, I don't know why my version of omedit was not up-to-date...

Thanks a lot,
Andrea

Note: See TracTickets for help on using tickets.