Opened 7 years ago

Closed 6 years ago

#4438 closed defect (fixed)

Change order of models in a sub-package does not work on multiple files

Reported by: Andrea Bartolini Owned by: Per Östlund
Priority: blocker Milestone: 1.14.0
Component: Interactive Environment Version: v1.12.0
Keywords: Cc:

Description

Try the following steps:
1) create a package Pack1 (save in different files)
2) create a model Mod1 in Pack1
3) create a model Mod2 in Pack1
4) save

in the package.order file of Pack1 the Mod1 and Mod2 are in the right order

5) move the Mod2 above Mod1
6) create a sub-package Pack2 in Pack1 (save in different files)
7) move Pack2 at the top of Pack1
8) save

in the package.order file of Pack1 the Pack2, Mod2 and Mod1 are still in the right order

9) create a Mod3 in the Pack2
10) create a Mod4 in the Pack2
11) save

in the package.order of Pack2 the Mod3 and Mod4 are in the right order

12) move Mod4 above Mod3
13) save

in the package.order of Pack2 the Mod3 and Mod4 order is left unchanged (wrong behavior).

OMEdit 1.12.0~dev-309-g2230a75
Connected to OpenModelica 1.12.0~dev-789-g42b0038
sysop: Ubuntu 16.04

Attachments (1)

Pack1.zip (1.9 KB ) - added by Adeel Asghar 7 years ago.

Download all attachments as: .zip

Change History (7)

by Adeel Asghar, 7 years ago

Attachment: Pack1.zip added

comment:1 by Adeel Asghar, 7 years ago

Component: OMEditInteractive Environment
Owner: changed from Adeel Asghar to Per Östlund
Status: newassigned

The problem seems to be with the moveClass API. It is not updating the AST for the nested packages.

Attachment contains a small example which could be used to reproduce the issue.

comment:2 by Francesco Casella, 7 years ago

Milestone: 1.12.01.13.0

Milestone moved to 1.13.0 due to 1.12.0 already being released.

comment:3 by Francesco Casella, 6 years ago

Milestone: 1.13.01.14.0

Rescheduled to 1.14.0 after 1.13.0 releasee

comment:4 by Francesco Casella, 6 years ago

Priority: criticalblocker

This should really be fixed in 1.14.0, it is an extremely annoying bug for serious developers.

comment:5 by Per Östlund, 6 years ago

Should be fixed in c53b5307.

in reply to:  5 comment:6 by Francesco Casella, 6 years ago

Resolution: fixed
Status: assignedclosed

Replying to perost:

Should be fixed in c53b5307.

It is, I just checked :)

Note: See TracTickets for help on using tickets.