Opened 7 years ago

Closed 7 years ago

#4461 closed defect (fixed)

OMEdit does not save additional simulation flags

Reported by: Andrea Bartolini Owned by: Adeel Asghar
Priority: critical Milestone: 1.12.0
Component: OMEdit Version: v1.12.0
Keywords: Cc:

Description

Try this experiment:

1) Write a simple model:

model M1
end M1;

2) Open Simulation Setup and put some flags in the Additional Simulation Flags field (e.g. -iim=symbolic -ils=5)

3) Check "Save _OpenModelica_simulationFlags annotation inside model" checkbox

4) Save

The Additional simulation flags are not saved, as shown below

model M1
  annotation(
    __OpenModelica_simulationFlags(jacobian = "", s = "dassl", lv = "LOG_STATS"));
end M1;

OMEdit 1.12.0~dev-320-g375731a
Connected to OpenModelica 1.12.0~dev-865-g260d930
Sysop: Ubuntu 16.04

Change History (3)

comment:1 by Adeel Asghar, 7 years ago

Resolution: fixed
Status: newclosed

Fixed in 90af74/OMEdit.

comment:2 by Adeel Asghar, 7 years ago

Resolution: fixed
Status: closedreopened

I made a bad fix by introducing a modifier additionalSimulationFlags which is not in accordance to other simulation flags. If the additional simulation flags are -iim=symbolic -ils=5 then the model should look like,

model M1
  annotation(
    __OpenModelica_simulationFlags(jacobian = "", s = "dassl", lv = "LOG_STATS", iim="symbolic" ils="5"));
end M1;

instead of,

model M1
  annotation(
    __OpenModelica_simulationFlags(jacobian = "", s = "dassl", lv = "LOG_STATS", additionalSimulationFlags="-iim=symbolic -ils=5"));
end M1;

I will try to fix it.

comment:3 by Adeel Asghar, 7 years ago

Resolution: fixed
Status: reopenedclosed

Fixed in 16bcbe/OMEdit.

Note: See TracTickets for help on using tickets.