Opened 7 years ago
Closed 7 years ago
#4531 closed enhancement (duplicate)
Enable unit checking by default
| Reported by: | Francesco Casella | Owned by: | Mahder Alemseged Gebremedhin |
|---|---|---|---|
| Priority: | high | Milestone: | 1.13.0 |
| Component: | Frontend | Version: | |
| Keywords: | Cc: | Andrea Bartolini |
Description
We have tested the unit checking feature -d=frontEndUnitCheck extensively and we believe it works nicely.
I would suggest to turn on this feature by default. We can't do this for 1.12.0 because of feature freeze, but I would recommend it for 1.13.0 (i.e., the master branch).
On one hand, this won't break any existing model, since it just issues warnings.
On the other hand, there is no reason why people should write models which are dimensionally inconsistent. Failure of unit checking is a clear indication of either a mistake in the declaration of variables, or of a wrong equation, or both.
So, I see no reason to keep this feature off by default. To the contrary, I believe it should become part of the forthcoming 1.13 beta so many more users have a chance of discovering potentially remaining bugs.
Change History (3)
comment:1 by , 7 years ago
follow-up: 3 comment:2 by , 7 years ago
This has effectively become a duplicate of #4629, which has more recent context.
comment:3 by , 7 years ago
| Resolution: | → duplicate |
|---|---|
| Status: | new → closed |
Replying to Christoph Buchner <buchner@…>:
This has effectively become a duplicate of #4629, which has more recent context.
I agree. In fact, we found there is a very good reason (namely, performance) not to turn this on by default when compiling to simulate, as discussed there.
I'll close this as duplicate.
I agree - this sounds very reasonable.