Opened 7 years ago

Closed 7 years ago

#4615 closed defect (fixed)

New unit checking performance

Reported by: Per Östlund Owned by: arunkumar palanisamy
Priority: high Milestone: 1.13.0
Component: New Instantiation Version: v1.13.0-dev-nightly
Keywords: Cc: Mahder Alemseged Gebremedhin

Description

The new unit checking has rather severe performance issues. Consider a model such as this:

connector C
  Real e;
  flow Real f;
end C;

model M
  C c1[100000], c2[100000];
equation
  connect(c1, c2);
end M;

The whole instantiation, including connection handling, scalarization and DAE conversion, takes about 3 seconds for me. The unit checking meanwhile takes 22 seconds.

Change History (1)

comment:1 by Per Östlund, 7 years ago

Milestone: Future1.13.0
Resolution: fixed
Status: newclosed

Fixed by sjoelund.se in c2f24bdf, which also reactivates the flag so that the unit checking can be turned off if needed. The performance could probably be improved further, but the most severe scaling issues have been fixed at least.

Note: See TracTickets for help on using tickets.